[FEATURE/IMPROVEMENT] Pass 'IdP Hint' to Keycloak #1101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add App Config option for 'IdP Hint' under Keycloak Authentication * refactor the authentication trigger mechanism to allow direct call to keyjclaok-js adapter login() function * remove `onLoad` from construction options (as it belongs to init())
✅ Deploy Preview for dashy-dev ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Changes preview: Legend: |
Lissy93
approved these changes
Feb 12, 2023
a-mnich
added a commit
to a-mnich/dashy
that referenced
this pull request
Feb 12, 2023
adamantike
added a commit
to adamantike/dashy
that referenced
this pull request
Feb 22, 2023
Introduced in Lissy93#1101, which updated `package.json` without refreshing the `yarn.lock` file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Category:
Feature improvement
Overview
When Keycloak is used with an external Identity Provider, it is possible to skip
the Keycloak login page and redirect the user directly to the specified IdP if the
idpHintlogin option is passed to the adapter. (See login())
This has been tested with
keycloak-jsversion20.0.3(to which this PR upgrades) against Keycloak server18.0.2so it should work with this and presumably newer versions of the server too. The new configuration option is optional and the standard Keycloak authentication is unaffected when not specified.New Vars (if applicable)
Added
appConfig.auth.keycloak.idpHintoptional configuration option.Code Quality Checklist (Please complete)