Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support searching multiple words. #1171

Merged
merged 2 commits into from
May 5, 2023
Merged

Conversation

ssrangisetti
Copy link
Contributor

@ssrangisetti ssrangisetti commented May 3, 2023

ssrangisetti Quick ssrangisetti /patch-1 → Lissy93/dashy Commits: 2 | Files Changed: 1 | Additions: 0 Label Unchecked Tasks Powered by Pull Request Badge

Category: Feature improvement

Overview
When search field has multiple words like quick fox or dog fox in string like The quick brown fox jumps over the lazy dog it would be helpful to search for each word in the sentence instead of considering entire search string as single word. If a user gives multiple space separated tags, this ensures that items which contain all the search tags are returned

Ex 1: compareStr: The quick brown fox jumps over the lazy dog, searchStr: dog fox, previous result: false, now: true
Ex 2: compareStr: ['abcd', 'xyz', 'pqr'], searchStr: abcd xyz, previous result: false, now: true

Code Quality Checklist (Please complete)

  • All changes are backwards compatible (not backwards compatible because search behaviour changed)
  • All lint checks and tests are passing
  • There are no (new) build warnings or errors
  • (If a new config option is added) Attribute is outlined in the schema and documented
  • (If a new dependency is added) Package is essential, and has been checked out for security or performance
  • Bumps version, if new feature added

@ssrangisetti ssrangisetti requested a review from Lissy93 as a code owner May 3, 2023 17:51
@netlify
Copy link

netlify bot commented May 3, 2023

Deploy Preview for dashy-dev ready!

Name Link
🔨 Latest commit 3f3ffac
🔍 Latest deploy log https://app.netlify.com/sites/dashy-dev/deploys/6452a71191fc4d0008650ea8
😎 Deploy Preview https://deploy-preview-1171--dashy-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@viezly
Copy link

viezly bot commented May 3, 2023

Changes preview:

Legend:

👀 Review pull request on Viezly

Copy link
Owner

@Lissy93 Lissy93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @ssrangisetti!

@Lissy93 Lissy93 merged commit 9a416a4 into Lissy93:master May 5, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants