Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REFACTOR] - Couple small things #135

Merged
merged 9 commits into from
Aug 8, 2021
Merged

Conversation

Lissy93
Copy link
Owner

@Lissy93 Lissy93 commented Aug 8, 2021

Lissy93 /REFACTOR/couple-small-things β†’ Lissy93/dashy Commits: 9 | Files Changed: 17 | Additions: 38 Powered by Pull Request Badge

Category: Code style update

Overview

  • f85dbe4 🐳 Adds yarn.lock into amd Dockerfile
  • c18fbe2 ✨ Enables user to self-host their own Sentry, and updates Privacy docs
  • e5227fb ✏️ Fixes small typos in docs
  • aa89a5b πŸ”’ Adds password verify check to cloud sync
  • e6cfad6 πŸ”₯ Removes view config screen, as not necessary
  • 3daee52🚸 Improve user experience of config modals
  • 47bc56a 🌐 Adds Missing Password text
  • db0bfe4 πŸ“ Updates the readme

Issue Number N/A

New Vars

  • sentryDsn boolean Optional: If you need to monitor errors in your instance, then you can use Sentry to collect and process bug reports. Sentry can be self-hosted, or used as SaaS, once your instance is setup, then all you need to do is pass in the DSN here, and enable error reporting. You can learn more on the Sentry DSN Docs. Note that this will only ever be used if enableErrorReporting is explicitly enabled.

Screenshot N/A

Code Quality Checklist (Please complete)

  • All changes are backwards compatible
  • All lint checks and tests are passing
  • There are no (new) build warnings or errors
  • (If a new config option is added) Attribute is outlined in the schema and documented
  • (If a new dependency is added) Package is essential, and has been checked out for security or performance
  • Bumps version, if new feature added

@Lissy93 Lissy93 requested a review from liss-bot as a code owner August 8, 2021 20:05
@netlify
Copy link

netlify bot commented Aug 8, 2021

βœ”οΈ Deploy Preview for dashy-dev ready!

πŸ”¨ Explore the source changes: 0b45c30

πŸ” Inspect the deploy log: https://app.netlify.com/sites/dashy-dev/deploys/611039f141d32e0008b01ebf

😎 Browse the preview: https://deploy-preview-135--dashy-dev.netlify.app/

@Lissy93 Lissy93 merged commit a4a1e56 into master Aug 8, 2021
@Lissy93 Lissy93 deleted the REFACTOR/couple-small-things branch August 8, 2021 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant