Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ConfigSchema.json #1395

Merged
merged 1 commit into from
Nov 30, 2023
Merged

Update ConfigSchema.json #1395

merged 1 commit into from
Nov 30, 2023

Conversation

jjmung
Copy link
Contributor

@jjmung jjmung commented Nov 21, 2023

jjmung Quick jjmung /jjmung-patch-1 → Lissy93/dashy Commits: 1 | Files Changed: 1 | Additions: 0 Powered by Pull Request Badge

Updates confusing wordage that aligns with docs

Thank you for contributing to Dashy! So that your PR can be handled effectively, please populate the following fields (delete sections that are not applicable)

Category:

Documentation / Other (Updates Description in Inner App Config window)

Overview

Updated confusing wordage in inner App configuration window that aligns with Docs

Issue Number (if applicable) N/A

New Vars (if applicable)

No new vars, only updated text description

Screenshot (if applicable)

NA

Code Quality Checklist (Please complete)

  • [ x] All changes are backwards compatible
  • All lint checks and tests are passing
  • [ X] There are no (new) build warnings or errors
  • (If a new config option is added) Attribute is outlined in the schema and documented
  • (If a new dependency is added) Package is essential, and has been checked out for security or performance
  • Bumps version, if new feature added

Updates confusing wordage that aligns with docs
@jjmung jjmung requested a review from Lissy93 as a code owner November 21, 2023 07:18
Copy link

vercel bot commented Nov 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dashy ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 21, 2023 7:19am

Copy link

netlify bot commented Nov 21, 2023

Deploy Preview for dashy-dev ready!

Name Link
🔨 Latest commit 0ef0bf0
🔍 Latest deploy log https://app.netlify.com/sites/dashy-dev/deploys/655c59d2b8f1960008788b1d
😎 Deploy Preview https://deploy-preview-1395--dashy-dev.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

viezly bot commented Nov 21, 2023

Changes preview:

Legend:

👀 Review pull request on Viezly

@Lissy93 Lissy93 merged commit 945e8c6 into Lissy93:master Nov 30, 2023
12 checks passed
@liss-bot
Copy link
Collaborator

liss-bot commented Mar 3, 2024

The fix for this issue has now been released in 2.1.2 ✨

If you haven't done so already, please update your instance to 2.1.2 or later. See 2.1.2 for full info.

Feel free to reach out if you need any more support. If you are enjoying Dashy, consider supporting the project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants