Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] - Support for Material Icons #141

Merged
merged 5 commits into from
Aug 9, 2021
Merged

Conversation

Lissy93
Copy link
Owner

@Lissy93 Lissy93 commented Aug 9, 2021

Lissy93 /FEATURE/brand-icon-support → Lissy93/dashy Commits: 5 | Files Changed: 8 | Additions: 91 Powered by Pull Request Badge

Category: Feature

Overview
Adds support for icons from https://dev.materialdesignicons.com/icons
To use, first find the name of your icon, and then set: icon: mdi-[name-of-icon]

E.g.

sections:
- name: Material Design Icons
  items:
  - title: I'm an Alien
    icon: mdi-alien 
  - title: I'm warm
    icon: mdi-fire 
  - title: I'm a Dino
    icon: mdi-google-downasaur 

Issue Number #139

New Vars N/A

Screenshot
image

Code Quality Checklist (Please complete)

  • All changes are backwards compatible
  • All lint checks and tests are passing
  • There are no (new) build warnings or errors
  • (If a new config option is added) Attribute is outlined in the schema and documented
  • (If a new dependency is added) Package is essential, and has been checked out for security or performance
  • Bumps version, if new feature added

@Lissy93 Lissy93 requested a review from liss-bot as a code owner August 9, 2021 22:08
@netlify
Copy link

netlify bot commented Aug 9, 2021

✔️ Deploy Preview for dashy-dev ready!

🔨 Explore the source changes: ab9c2ad

🔍 Inspect the deploy log: https://app.netlify.com/sites/dashy-dev/deploys/6111a8a3b4011c00071382f8

😎 Browse the preview: https://deploy-preview-141--dashy-dev.netlify.app/

Re: #139 - Implementation for Material-Design-Icons
Copy link
Owner Author

@Lissy93 Lissy93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Will merge when all checks complete successfully.

@Lissy93 Lissy93 merged commit ff1249b into master Aug 9, 2021
@Lissy93 Lissy93 deleted the FEATURE/brand-icon-support branch August 22, 2021 14:22
asterling8516 pushed a commit to asterling8516/dashy that referenced this pull request Nov 23, 2023
Closes Lissy93#141

Signed-off-by: Bjorn Lammers <walkxnl@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant