Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reserialize and serialize jsonconfig #1470

Merged
merged 1 commit into from Feb 22, 2024
Merged

Conversation

CrazyWolf13
Copy link
Collaborator

@CrazyWolf13 CrazyWolf13 commented Feb 22, 2024

CrazyWolf13 Quick CrazyWolf13 /master → Lissy93/dashy Commits: 1 | Files Changed: 1 | Additions: 2 Powered by Pull Request Badge

Category:

One of: Bugfix

Overview

stringify the jsonConfig
parse to js object
convert to yml

Those: don't show up on new installations and old installations should go automatically away by rebuilding, editing through gui and then rebuilding again or so.

image

Issue Number #1361

New Vars (if applicable)

const strjsonConfi
const jsonObj

Code Quality Checklist (Please complete)

  • [ x ] All changes are backwards compatible
  • [ x ] All lint checks and tests are passing
  • [ x ] There are no (new) build warnings or errors
  • [ ] Bumps version, if new feature added

Copy link

vercel bot commented Feb 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dashy ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 22, 2024 8:18pm

Copy link

netlify bot commented Feb 22, 2024

Deploy Preview for dashy-dev ready!

Name Link
🔨 Latest commit 076b1d1
🔍 Latest deploy log https://app.netlify.com/sites/dashy-dev/deploys/65d7abea6c87090008116620
😎 Deploy Preview https://deploy-preview-1470--dashy-dev.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Owner

@Lissy93 Lissy93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @CrazyWolf13!

@Lissy93 Lissy93 merged commit 1f5274b into Lissy93:master Feb 22, 2024
9 checks passed
@liss-bot
Copy link
Collaborator

liss-bot commented Mar 3, 2024

The fix for this issue has now been released in 2.1.2 ✨

If you haven't done so already, please update your instance to 2.1.2 or later. See 2.1.2 for full info.

Feel free to reach out if you need any more support. If you are enjoying Dashy, consider supporting the project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants