Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update german translation #1482

Merged
merged 2 commits into from
Mar 2, 2024
Merged

Update german translation #1482

merged 2 commits into from
Mar 2, 2024

Conversation

Kuchenmampfer
Copy link

@Kuchenmampfer Kuchenmampfer commented Mar 2, 2024

Kuchenmampfer Medium Kuchenmampfer /master → Lissy93/dashy Commits: 2 | Files Changed: 1 | Additions: 27 Label Unchecked Tasks Powered by Pull Request Badge

Category:
Translation

Overview
I updated the german translation. I have two notes to add:

  • the diff is huge, but most of it comes from prettyfying the json. If you want to check, what I really did, I recommend checking out the individual commits
  • The {plural} extensions in some of the Nextcloud entries in reality do nothing but add an s. This leads to wrong gramattics in german, so I removed them.

Code Quality Checklist
I have not checked any of this explicitly, but as I only changed translation strings, I assume that it should not mess anything up.

  • All changes are backwards compatible
  • All lint checks and tests are passing
  • There are no (new) build warnings or errors
  • Bumps version, if new feature added

Copy link

vercel bot commented Mar 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dashy ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 2, 2024 11:17am

Copy link

netlify bot commented Mar 2, 2024

Deploy Preview for dashy-dev ready!

Name Link
🔨 Latest commit 1d09b61
🔍 Latest deploy log https://app.netlify.com/sites/dashy-dev/deploys/65e30a7aefa88c0008963255
😎 Deploy Preview https://deploy-preview-1482--dashy-dev.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Owner

@Lissy93 Lissy93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, danke 🍻

@Lissy93 Lissy93 merged commit b69daeb into Lissy93:master Mar 2, 2024
7 checks passed
@Kuchenmampfer
Copy link
Author

Ooh, a german answer, very nice :)
Bitte, sehr gerne

@liss-bot
Copy link
Collaborator

liss-bot commented Mar 3, 2024

The fix for this issue has now been released in 2.1.2 ✨

If you haven't done so already, please update your instance to 2.1.2 or later. See 2.1.2 for full info.

Feel free to reach out if you need any more support. If you are enjoying Dashy, consider supporting the project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants