Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Memory issue (WIP) #1510

Merged
merged 1 commit into from
Mar 26, 2024
Merged

[FIX] Memory issue (WIP) #1510

merged 1 commit into from
Mar 26, 2024

Conversation

Lissy93
Copy link
Owner

@Lissy93 Lissy93 commented Mar 14, 2024

Quick 🧱 Work in Progress Lissy93 /FIX/memory-issues-1500 → Lissy93/dashy Commits: 1 | Files Changed: 1 | Additions: 0 Unchecked Tasks Powered by Pull Request Badge

This is a draft, experimenting with going back to the Vue CLI to handle the rebuilding.

Previously this approach introduced a bug which caused a rebuild loop, which was why the new watch-for-changes function was written, but that function is memory intensive. But there have been some architectural changes since, so I'm giving this a second shot.

This will not be merged until I can verify 100% that it does not re-introduce the old infinite rebuild loop bug.

Category: Bugfix

Overview

Briefly outline your new changes...

Issue Number #1500

New Vars N/A

Screenshot N/A

Code Quality Checklist (Please complete)

  • All changes are backwards compatible
  • All lint checks and tests are passing
  • There are no (new) build warnings or errors
  • (If a new config option is added) Attribute is outlined in the schema and documented
  • (If a new dependency is added) Package is essential, and has been checked out for security or performance
  • Bumps version, if new feature added

Copy link

vercel bot commented Mar 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
dashy ✅ Ready (Inspect) Visit Preview Mar 14, 2024 6:20am

Copy link

netlify bot commented Mar 14, 2024

Deploy Preview for dashy-dev ready!

Name Link
🔨 Latest commit 6268584
🔍 Latest deploy log https://app.netlify.com/sites/dashy-dev/deploys/65f29716f1ea220008ced5d9
😎 Deploy Preview https://deploy-preview-1510--dashy-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Lissy93 Lissy93 added the 🚑 Hot Fix [ISSUE] Fixes critical issue, deploy asap label Mar 14, 2024
@CrazyWolf13
Copy link
Collaborator

So I did a lot of testing and could't replicate the very high consuming (1.5GB RAM usage) anymore.

I could also not replicate the rebuild loop even with the new command as stated above.

However there are still benefits when going back to vue cli ->

  • RAM usage slighly lower possibly makes it running on less than 1GB RAM
  • Faster
  • Slightly less CPU intensive

I will test for some more time and keep you updated, if I notice anything.

Thanks!

@CrazyWolf13
Copy link
Collaborator

I have tested with that command for a long time now and did not experience a single loop, so I think this can be merged and pushed to docker images etc.

@Lissy93 Lissy93 marked this pull request as ready for review March 26, 2024 18:58
@Lissy93 Lissy93 merged commit 60fc852 into master Mar 26, 2024
9 checks passed
@Lissy93 Lissy93 deleted the FIX/memory-issues-1500 branch March 26, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚑 Hot Fix [ISSUE] Fixes critical issue, deploy asap
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants