Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Auth headers for widgets #1576

Merged
merged 1 commit into from
May 9, 2024
Merged

[FIX] Auth headers for widgets #1576

merged 1 commit into from
May 9, 2024

Conversation

Lissy93
Copy link
Owner

@Lissy93 Lissy93 commented May 9, 2024

Medium Lissy93 /FIX/widget-header-auth → Lissy93/dashy Commits: 1 | Files Changed: 1 | Additions: -31 Label Unchecked Tasks Powered by Pull Request Badge

I made a change in v3 which removed the use of axios. This broke header auth for widgets, so this PR just reverts that change, putting axios back in and (hopefully 🤞) fixing the bug.

Category: Bugfix

Overview

Briefly outline your new changes...

Issue Number #1549

New Vars N/A

Screenshot _N/A

Code Quality Checklist (Please complete)

  • All changes are backwards compatible
  • All lint checks and tests are passing
  • There are no (new) build warnings or errors
  • (If a new config option is added) Attribute is outlined in the schema and documented
  • (If a new dependency is added) Package is essential, and has been checked out for security or performance
  • Bumps version, if new feature added

@Lissy93 Lissy93 requested a review from CrazyWolf13 May 9, 2024 23:17
Copy link

netlify bot commented May 9, 2024

Deploy Preview for dashy-dev ready!

Name Link
🔨 Latest commit 46e1c20
🔍 Latest deploy log https://app.netlify.com/sites/dashy-dev/deploys/663d59a8c17ab900080f088f
😎 Deploy Preview https://deploy-preview-1576--dashy-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Lissy93 Lissy93 merged commit b97ba74 into master May 9, 2024
8 checks passed
@Lissy93 Lissy93 deleted the FIX/widget-header-auth branch May 10, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant