Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Date parsing on Safari for the Public Holidays widget #1577

Merged
merged 1 commit into from
May 10, 2024

Conversation

Lissy93
Copy link
Owner

@Lissy93 Lissy93 commented May 10, 2024

🐛 Fix Quick Lissy93 /FIX/holiday-widget → Lissy93/dashy Commits: 1 | Files Changed: 1 | Additions: 3 Unchecked Tasks Powered by Pull Request Badge

Category: Bugfix

Overview
Safari being "special". Doesn't accept dates which don't include a time.
PR just adds a time (midnight) onto the dates returned by the API.

Issue Number #1532

New Vars N/A

Screenshot N/A

Code Quality Checklist (Please complete)

  • All changes are backwards compatible
  • All lint checks and tests are passing
  • There are no (new) build warnings or errors
  • (If a new config option is added) Attribute is outlined in the schema and documented
  • (If a new dependency is added) Package is essential, and has been checked out for security or performance
  • Bumps version, if new feature added

@Lissy93 Lissy93 added the 🦋 Bug Fix [PR] Code includes bug fixes label May 10, 2024
@Lissy93 Lissy93 requested a review from CrazyWolf13 May 10, 2024 00:00
Copy link

netlify bot commented May 10, 2024

Deploy Preview for dashy-dev ready!

Name Link
🔨 Latest commit 72d2f1b
🔍 Latest deploy log https://app.netlify.com/sites/dashy-dev/deploys/663d6385c8df4b0007b4217e
😎 Deploy Preview https://deploy-preview-1577--dashy-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Lissy93 Lissy93 merged commit eea193a into master May 10, 2024
7 checks passed
@Lissy93 Lissy93 deleted the FIX/holiday-widget branch May 10, 2024 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🦋 Bug Fix [PR] Code includes bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant