Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deployment.md #1636

Merged
merged 1 commit into from
Jul 9, 2024
Merged

Update deployment.md #1636

merged 1 commit into from
Jul 9, 2024

Conversation

danfein
Copy link
Contributor

@danfein danfein commented Jul 9, 2024

danfein Quick danfein /patch-1 → Lissy93/dashy Commits: 1 | Files Changed: 1 | Additions: 0 Label Unchecked Tasks Powered by Pull Request Badge

Update docker compose port to match docker and docker Quickstart sections

Category:

One of: Documentation

Overview

The port number in the docker compose section (4000) was out of sync with the documentation for the docker and quickstart sections (8080)

Issue Number (if applicable) #00

New Vars (if applicable)

n/a

Screenshot (if applicable)

If you've introduced any significant UI changes, please include a screenshot

Code Quality Checklist (Please complete)

  • All changes are backwards compatible
  • All lint checks and tests are passing
  • There are no (new) build warnings or errors
  • (If a new config option is added) Attribute is outlined in the schema and documented
  • (If a new dependency is added) Package is essential, and has been checked out for security or performance
  • (If significant change) Bumps version in package.json

Update docker compose port to match docker and docker Quickstart sections
@danfein danfein requested a review from Lissy93 as a code owner July 9, 2024 01:17
Copy link

netlify bot commented Jul 9, 2024

👷 Deploy Preview for dashy-dev processing.

Name Link
🔨 Latest commit 2f450e7
🔍 Latest deploy log https://app.netlify.com/sites/dashy-dev/deploys/668c8fb24af5150009bafde5

@Lissy93 Lissy93 merged commit d3d1de6 into Lissy93:master Jul 9, 2024
8 checks passed
@danfein danfein deleted the patch-1 branch July 11, 2024 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants