Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Allow for status checks to non-HTTPS content #182

Merged
merged 11 commits into from
Aug 27, 2021

Conversation

Lissy93
Copy link
Owner

@Lissy93 Lissy93 commented Aug 26, 2021

Lissy93 /FEATURE/ssl-status-check-options → Lissy93/dashy Commits: 11 | Files Changed: 14 | Additions: 70 Powered by Pull Request Badge

Category: Feature

Overview
By default, requests to insecure or non-HTTPS content should be blocked. This will likely cause the status check to fail. This PR adds an option for the user to disable this security measure for an individual endpoint, if they trust it. This is done by setting statusCheckAllowInsecure: true

Also:

  • Updates the .env template, plus the variables used in the server
  • Uses the v-cloak to hide text before it's finished loading
  • Fixed the parsing of the update-checker during build

Issue Number #181

New Vars (if applicable)
item[n].statusCheckAllowInsecure - Optional boolean - If set to true, then security checking is disabled.

Screenshot N/A

Code Quality Checklist (Please complete)

  • All changes are backwards compatible
  • All lint checks and tests are passing
  • There are no (new) build warnings or errors
  • (If a new config option is added) Attribute is outlined in the schema and documented
  • (If a new dependency is added) Package is essential, and has been checked out for security or performance
  • Bumps version, if new feature added

@netlify
Copy link

netlify bot commented Aug 26, 2021

✔️ Deploy Preview for dashy-dev ready!

🔨 Explore the source changes: f343af3

🔍 Inspect the deploy log: https://app.netlify.com/sites/dashy-dev/deploys/6128083e6e597b000756390d

😎 Browse the preview: https://deploy-preview-182--dashy-dev.netlify.app/

@viezly
Copy link

viezly bot commented Aug 26, 2021

Changes preview:

👀 Review pull request on Viezly

@netlify
Copy link

netlify bot commented Aug 26, 2021

✔️ Deploy Preview for dashy-dev ready!

🔨 Explore the source changes: ff663f8

🔍 Inspect the deploy log: https://app.netlify.com/sites/dashy-dev/deploys/61294206bfebbd00076e7b92

😎 Browse the preview: https://deploy-preview-182--dashy-dev.netlify.app/

@Lissy93
Copy link
Owner Author

Lissy93 commented Aug 26, 2021

Still to do

  • Fix small UI issue on the status check tooltip
  • Update the environmental variable for printMsg
  • Test on hosted instance, with mixed content status checks
  • Maybe include the quick fix for version checking in this PR
  • Bump version and update changelog

🌃 Will finish this tomorrow evening...

@Lissy93 Lissy93 merged commit e3b364f into master Aug 27, 2021
@Lissy93 Lissy93 deleted the FEATURE/ssl-status-check-options branch August 27, 2021 19:57
asterling8516 pushed a commit to asterling8516/dashy that referenced this pull request Nov 23, 2023
Closes Lissy93#182

Signed-off-by: Bjorn Lammers <walkxnl@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant