Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Adds support for proxying CORS requests #392

Merged
merged 13 commits into from Jan 1, 2022

Conversation

Lissy93
Copy link
Owner

@Lissy93 Lissy93 commented Dec 30, 2021

✨ Feature Medium Lissy93 /FEATURE/add-request-proxy → Lissy93/dashy Commits: 13 | Files Changed: 17 | Additions: 90

Category: Improvement

Overview
Some users reporting facing CORS issues with the Pi-Hole widget. This option adds a new option that can be applied to a widget (useProxy) that will route the request through the Node proxy server, which contains the right headers.

Issue Number #231, #391

New Vars

  • useProxy - boolean, optional

Screenshot N/A

Code Quality Checklist (Please complete)

  • All changes are backwards compatible
  • All lint checks and tests are passing
  • There are no (new) build warnings or errors
  • (If a new config option is added) Attribute is outlined in the schema and documented
  • (If a new dependency is added) Package is essential, and has been checked out for security or performance
  • Bumps version, if new feature added

@netlify
Copy link

netlify bot commented Dec 30, 2021

✔️ Deploy Preview for dashy-dev ready!

🔨 Explore the source changes: 746a377

🔍 Inspect the deploy log: https://app.netlify.com/sites/dashy-dev/deploys/61cfab1e34857e0007ace80f

😎 Browse the preview: https://deploy-preview-392--dashy-dev.netlify.app/

@liss-bot liss-bot added the ✨ New Feature [PR] Contains implementation of a new feature label Dec 30, 2021
@viezly
Copy link

viezly bot commented Dec 30, 2021

This pull request is split into 4 parts for easier review.
👀 Review pull request on Viezly

Changed files are located in these folders:

  • /
  • docs
  • services
  • src/assets/locales
  • src/components/Widgets
  • src/mixins

@Lissy93
Copy link
Owner Author

Lissy93 commented Dec 30, 2021

Before merging, I should probably also add this option to other widgets for self-hosted services. To prevent the same issue, and to keep things consistent.

Not yet sure if I need to add a cloud function for Netlify too. Since users hosting the app on Netlify won't be able to integrate with locally-self-hosted apps, it might not be needed.

I also still need to also add this option to the Configuring docs, bump version and update changelog.

@Lissy93 Lissy93 merged commit 3b7d5a6 into master Jan 1, 2022
@Lissy93 Lissy93 deleted the FEATURE/add-request-proxy branch January 1, 2022 01:18
@Lissy93
Copy link
Owner Author

Lissy93 commented Jan 1, 2022

Fixes #391

@Lissy93 Lissy93 linked an issue Jan 1, 2022 that may be closed by this pull request
4 tasks
@liss-bot
Copy link
Collaborator

The fix for this issue has now been released in Dashy 2.0.0 ✨

If you haven't done so already, please update your instance to 2.0.0 or later. See Dashy 2.0.0 for full info.

Feel free to reach out if you need any more support. If you are enjoying Dashy, consider supporting the project.

asterling8516 pushed a commit to asterling8516/dashy that referenced this pull request Nov 23, 2023
Co-authored-by: Dashboard Icons Bot <noreply@walkx.fyi>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 Fixed ✨ New Feature [PR] Contains implementation of a new feature 🛩️ Released 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[QUESTION] What am I missing/doing wrong in the Pi Hole Stats widget?
2 participants