🐛 Fix context menu on mobile/touch devices #541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for dashy-dev ready! 🔨 Explore the source changes: 8ee7847 🔍 Inspect the deploy log: https://app.netlify.com/sites/dashy-dev/deploys/62273640759fbf0007eb854e 😎 Browse the preview: https://deploy-preview-541--dashy-dev.netlify.app/ |
|
Changes preview: Legend: |
Lissy93
approved these changes
Mar 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Dashy! So that your PR can be handled effectively, please populate the following fields (delete sections that are not applicable)
Category:
Bugfix
Overview
This proposal adds a method of accessing the context menu on touchscreen devices which don't have a right click action. This is achieved by adding a button to open the menu, that also helps with indicating that a menu is available.
While working on this I noticed another issue with the menu positioning and changed the menu to ensure it no longer extends past the edge of the window and within it's own section.
Issue Number #508
Screenshot (if applicable)
Before:
After:
Code Quality Checklist (Please complete)