Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REFACTOR] General small app improvements #57

Merged
merged 23 commits into from
Jun 23, 2021

Conversation

Lissy93
Copy link
Owner

@Lissy93 Lissy93 commented Jun 23, 2021

Please check the type of change your PR introduces:

  • Bugfix
  • Feature

Issue Number (if applicable): #54 , #55 and #41

Briefly outline your changes:

  • Adds license
  • Improves service workers, and adds serviceWorkerStatus local storage item [BUG] Service worker is hard-caching website #54
  • Adds missing statusCheck and statusCheckInterval docs into Configuring.md
  • Adds an About App page, containing info needed to raise a bug report
  • Adds TDLR license into main readme
  • Introduces app versioning
  • Adds safeguards into ConfigAccumalaror, to prevent error being thrown
  • Updates PR template
  • Improved Webpack build experience, with progress bar and completion notification
  • Adds new and improved icons for layout options
  • (Finally) fixed the sticky footer so that it is now stickey
  • Make the Page Title into a home page link
  • Adds some sexy ascii art into the welcome message
  • Adds missing favicon, Re: [BUG] Favicon not present #55
  • Adds assets to PWA manifest.json
  • Documents app commands in readme
  • Enable passing website as URL param to the workspace
  • Modified items, so that title text doesn't get shortened, Re: [BUG] Title cut when icon size is set to small #41

Before submitting, please ensure that:

  • Must be backwards compatible
  • All lint checks and tests must pass
  • If a new option in the the config file is added, it needs to be added into the schema, and documented in the configuring guide
  • If a new dependency is required, it must be essential, and it must be thoroughly checked out for security or efficiency issues

@vercel
Copy link

vercel bot commented Jun 23, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/alicia/dashy/FBmQQxXnDvbaorH4jrc8gEEiKWZM
✅ Preview: https://dashy-git-refactorsw-improvments-and-docs-alicia.vercel.app

@netlify
Copy link

netlify bot commented Jun 23, 2021

✔️ Deploy Preview for dashy-dev ready!

🔨 Explore the source changes: 4a2c996

🔍 Inspect the deploy log: https://app.netlify.com/sites/dashy-dev/deploys/60d39b6ca3803500074760d6

😎 Browse the preview: https://deploy-preview-57--dashy-dev.netlify.app

@Lissy93 Lissy93 mentioned this pull request Jun 23, 2021
@vercel vercel bot temporarily deployed to Preview June 23, 2021 20:37 Inactive
@Lissy93 Lissy93 merged commit e6da1c4 into master Jun 23, 2021
@Lissy93 Lissy93 deleted the REFACTOR_sw-improvments-and-docs branch June 23, 2021 20:40
asterling8516 pushed a commit to asterling8516/dashy that referenced this pull request Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant