Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Implements a 'Remember Me' dropdown to Login form #66

Merged
merged 2 commits into from
Jun 26, 2021

Conversation

Lissy93
Copy link
Owner

@Lissy93 Lissy93 commented Jun 26, 2021

Category: Feature

Overview

Previously the login was set to expire at the end of the users session, but Chromium browsers will suspend open tabs that are inactive for a certain period of time, to preserve memory, causing the session to expire prematurely, and you to be logged out. I see that this probably isn't the desirable behavior, so I will implement an option for the user to specify how long they'd like to stay logged in for, and this will be preserved even when the user closes their browser/ ends the session.

This small PR implements a dropdown menu, enabling the user to select how long they would like to stay logged in for. It then adds this value into the auth token's expiry, stored in the browser.

Issue Number #64

New Vars N/A

Screenshot (if applicable)

If you've introduced any significant UI changes, please include a screenshot

Code Quality Checklist (Please complete)

  • All changes are backwards compatible
  • All lint checks and tests are passing
  • There are no (new) build warnings or errors
  • (If a new config option is added) Attribute is outlined in the schema and documented
  • (If a new dependency is added) Package is essential, and has been checked out for security or performance

@netlify
Copy link

netlify bot commented Jun 26, 2021

✔️ Deploy Preview for dashy-dev ready!

🔨 Explore the source changes: ee5bb9c

🔍 Inspect the deploy log: https://app.netlify.com/sites/dashy-dev/deploys/60d704aabaedf90008b9908b

😎 Browse the preview: https://deploy-preview-66--dashy-dev.netlify.app/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant