Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed some styling bugs #2

Closed
wants to merge 1 commit into from
Closed

fixed some styling bugs #2

wants to merge 1 commit into from

Conversation

AadityaJain-Dev
Copy link

@AadityaJain-Dev AadityaJain-Dev commented Jul 17, 2023

While using the website on chrome (Windows OS) I noticed that there is a white space around the <main> tag wrapper.
The changes I made should fix it.

@netlify
Copy link

netlify bot commented Jul 17, 2023

Deploy Preview for web-check ready!

Name Link
🔨 Latest commit e7dbca4
🔍 Latest deploy log https://app.netlify.com/sites/web-check/deploys/64b5099f88ba5a00089880bf
😎 Deploy Preview https://deploy-preview-2--web-check.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Owner

@Lissy93 Lissy93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heya @AadityaJain-Dev - Thanks for the PR :)
But I think this breaks the alignment of the homepage

Original PR Version
image image

Though I have just realized that I forgot to test on any Chromium-based browsers, and it does look like the positioning is slightly different from Firefox, so I'll look into that. Can you share a screenshot of the broken whitespace, as I don't see that on my end?

@AadityaJain-Dev
Copy link
Author

Hey,
sorry for the late reply, I was travelling.
anyway, I am not able to reproduce the issue which I was facing that day, so I guess I will just close the PR.

PS
nice project :)

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants