Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create List-KR experimental #412

Merged
merged 4 commits into from
Jun 15, 2022
Merged

Create List-KR experimental #412

merged 4 commits into from
Jun 15, 2022

Conversation

piquark6046
Copy link
Member

@piquark6046 piquark6046 commented Jun 15, 2022

@piquark6046 piquark6046 self-assigned this Jun 15, 2022
@piquark6046 piquark6046 added the enhancement New feature or request label Jun 15, 2022
@piquark6046 piquark6046 requested review from JobcenterTycoon, seia-soto and green1052 and removed request for JobcenterTycoon June 15, 2022 14:16
@piquark6046
Copy link
Member Author

@gaeulbyul

@piquark6046 piquark6046 marked this pull request as ready for review June 15, 2022 14:17
Copy link
Collaborator

@green1052 green1052 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gaeulbyul
Copy link
Contributor

👍 파일이 따로 나뉘게 된 만큼 README에 해당 필터를 설치하는 방법에 대한 안내가 있다면 더 좋을 거 같아요.

@green1052
Copy link
Collaborator

green1052 commented Jun 15, 2022

what's min value for Expires header?

if less 1 day better set 1 hour

@JobcenterTycoon
Copy link
Collaborator

JobcenterTycoon commented Jun 15, 2022

So we have the regular filter and the experemential one and the user need to import the experemential one?

Im wondering why all redirect and whitelist filter get moved too because they aren’t problematic. The only problematic filter for Ad-Shield i see are:

/:\/\/[a-z\.]+\/[a-zA-Z\.\_]{1,30}\/[a-zA-Z\.\_]{1,30}\/[a-zA-Z0-9\.\_\/]+\.(eps|jar|pls|pict|xls|xlsx|mid|midi|avif|pdf|ps|webp|ppt|csv|doc|docx|tif|tiff|class|pptx)$/$doc,popup,inline-script,1p,domain=ppss.kr|ygosu.com|loawa.com|feedclick.net|dailian.co.kr|inven.co.kr
/:\/\/[a-z\.]+\/[a-zA-Z0-9]{10,15}\.(eps|jar|pls|pict|xls|xlsx|mid|midi|avif|pdf|ps|webp|ppt|csv|doc|docx|tif|tiff|class|pptx)$/$doc,popup,inline-script,1p,domain=ppss.kr|ygosu.com|loawa.com|feedclick.net|dailian.co.kr|inven.co.kr
/:\/\/[a-z\.]+\/[a-zA-Z\.\_]{1,15}\/[a-zA-Z0-9\.]{5,25}\.(eps|jar|pls|pict|xls|xlsx|mid|midi|avif|pdf|ps|webp|ppt|csv|doc|docx|tif|tiff|class|pptx)$/$doc,popup,inline-script,1p,domain=ppss.kr|ygosu.com|loawa.com|feedclick.net|dailian.co.kr|inven.co.kr

loawa.com,ppss.kr,feedclick.net,ygosu.com##style+div:nth-last-child(1)
loawa.com,ppss.kr,feedclick.net,ygosu.com#$#div[id]>div[id]>img[src] { display: none; }

@green1052 uBO will round it to 1 day

@piquark6046
Copy link
Member Author

piquark6046 commented Jun 15, 2022

So we have the regular filter and the experemential one and the user need to import the experemential one?

No. Importing the experemential one does not required.
I and @gaeulbyul hope that these changes make a user keeping List-KR in their filters list.

If a user want to block these advertisement, the user can add microShield or NamuLink into their userscript manager.

Im wondering why all redirect and whitelist filter get moved too because they aren’t problematic. The only problematic filter for Ad-Shield i see are:

A $redirect-rule filter can be detected by measuring the size of responded data.

@piquark6046
Copy link
Member Author

Copy link
Contributor

@seia-soto seia-soto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In case of, if we have a proper CI system for commenting the rules marked automatically, we can have an opt-out approach for users to try to block the ads by default. Lay people don't see the these mechanism in general.

I am requesting some changes:

  1. Additional description for List-KR Experimental.

We need a proper reason for users. For example:

  • All AdShield and NamuWiki related rules are moved to experimental filter to resolve high rate of rule resulting false-positive.
  • You can opt-in to these rules to block ads on complex sites using only AdBlocker rules by adding List-KR experimental.
  1. Listing method

List-KR experimental is the filter that can be handled actively not only maintainers but also outside collaborators of List-KR. How about making it more describable by adding some issue URLs?

Partially, I basically agree with @JobcenterTycoon and want to leave non-problematic rules. However, to make the situation clear for lay people, I think we need to completely detach the rules.

@piquark6046
Copy link
Member Author

piquark6046 commented Jun 15, 2022

@seia-soto Please re-review 1c77f4a.

@piquark6046 piquark6046 merged commit 0fe31b4 into master Jun 15, 2022
@seia-soto
Copy link
Contributor

@seia-soto Please re-review 1c77f4a.

I agree with you. Sorry for recent late replying. But I think I'll delay some development works next 2 weeks (maybe). School test period is coming.

@JobcenterTycoon
Copy link
Collaborator

JobcenterTycoon commented Jun 15, 2022

Better is to move a filter back to the regular one:

loawa.com#?##equip-info-modal:has(> .modal-dialog > .modal-content > .modal-body > button.close + button.float-right) is needed to fix the broken overlay

piquark6046 added a commit that referenced this pull request Jun 15, 2022
#412 (comment)
#277

Co-authored-by: JobcenterTycoon <48647394+JobcenterTycoon@users.noreply.github.com>
@green1052 green1052 deleted the suggestion/411 branch June 19, 2022 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(제안) 애드쉴드/나무위키 필터를 별도 파일로 분리하면 어떨까요?
6 participants