-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create List-KR experimental #412
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
👍 파일이 따로 나뉘게 된 만큼 README에 해당 필터를 설치하는 방법에 대한 안내가 있다면 더 좋을 거 같아요. |
what's min value for Expires header? if less 1 day better set 1 hour |
So we have the regular filter and the experemential one and the user need to import the experemential one? Im wondering why all redirect and whitelist filter get moved too because they aren’t problematic. The only problematic filter for Ad-Shield i see are:
@green1052 uBO will round it to 1 day |
No. Importing the experemential one does not required. If a user want to block these advertisement, the user can add microShield or NamuLink into their userscript manager.
A |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In case of, if we have a proper CI system for commenting the rules marked automatically, we can have an opt-out approach for users to try to block the ads by default. Lay people don't see the these mechanism in general.
I am requesting some changes:
- Additional description for List-KR Experimental.
We need a proper reason for users. For example:
- All AdShield and NamuWiki related rules are moved to experimental filter to resolve high rate of rule resulting false-positive.
- You can opt-in to these rules to block ads on complex sites using only AdBlocker rules by adding List-KR experimental.
- Listing method
List-KR experimental is the filter that can be handled actively not only maintainers but also outside collaborators of List-KR. How about making it more describable by adding some issue URLs?
Partially, I basically agree with @JobcenterTycoon and want to leave non-problematic rules. However, to make the situation clear for lay people, I think we need to completely detach the rules.
@seia-soto Please re-review 1c77f4a. |
I agree with you. Sorry for recent late replying. But I think I'll delay some development works next 2 weeks (maybe). School test period is coming. |
Better is to move a filter back to the regular one:
|
#412 (comment) #277 Co-authored-by: JobcenterTycoon <48647394+JobcenterTycoon@users.noreply.github.com>
나무위키 하단 파워링크 광고와 애드쉴드 문제 해결하기
Resolve #411.