LF-3079 Replace Digital Ocean Spaces with MinIO for the development environment #2515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use aws configure to set the access key and secret access key, and make sure that region is removed from the aws config
|
Thanks for this one Joyce and @arcijsg for suggesting MinIO. Definitely already used this a few times For surveystack and document export reviews and has worked well!
|
SayakaOno
reviewed
Mar 24, 2023
Comment on lines
27
to
28
| url.hostname = 'images.litefarm.workers.dev'; | ||
| const url = new URL(fileUrl); |
There was a problem hiding this comment.
These two lines should be swapped, right...?
There was a problem hiding this comment.
Oh goodness 🤦♀️ Thank you
|
In case you haven't seen it, you have a conflict in |
|
@Duncan-Brain could you check the new README.md addition? And here's a Jira ticket for localizing the Imaginary: LF-3081. Good idea. |
Duncan-Brain
approved these changes
Mar 28, 2023
SayakaOno
approved these changes
Mar 28, 2023
iperdomo
deleted the
LF-3079-Add-MinIO-integration-to-development-environment-to-allow-localhost-document-export-and-download
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
On beta & production, document upload and certification documents export both use a paid Digital Ocean Spaces service for storage. Developers currently can’t test these services locally without significant refactors to the user flow or using their own DIgital Oceans Spaces / AWS S3 accounts.
MinIO is a free and open-source drop-in replacement for AWS S3 that can be set up and run locally completely free of charge. Adding MinIO compatibility to the developer environment allows developers to locally test certification export and document upload and download in their local environments.
Instructions for using MinIO with the export server can be found on Confluence here: Running the export server locally
These code changes were made specifically for use with the guide above, and remove hardcoded references to the Digital Ocean Spaces bucket in the 1) certification document export, 2) download of certification documents, and 3) document upload & download.
A NOTE ABOUT IMAGES: Image upload and download are handled by the LiteFarm Imaginary which I believe is a Digital Ocean Droplet and not a Digital Ocean Space. Image upload and download don't currently work locally, and this PR will not fix that. That feature would be a great addition for a developer to pick up in the future!
Jira link: https://lite-farm.atlassian.net/jira/software/c/projects/LF/issues/LF-3079
Type of change
.env.defaultHow Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
This branch has been used by myself, @SayakaOno and @Duncan-Brain to test the SurveyStack ticket LF-2990.
Checklist: