Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LF-3921d Fix nginx 'rewrite or internal redirection cycle while internally redirecting to "/index.html"' error #3030

Merged
merged 5 commits into from
Dec 7, 2023
Merged

LF-3921d Fix nginx 'rewrite or internal redirection cycle while internally redirecting to "/index.html"' error #3030

merged 5 commits into from
Dec 7, 2023

Commits on Dec 6, 2023

  1. LF-3921d Restore index.html location block

    @kathyavini
    kathyavini committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    69c53b3 View commit details
    Browse the repository at this point in the history

  2. LF-3921d Restore root to location / block

    @kathyavini
    kathyavini committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    370303e View commit details
    Browse the repository at this point in the history

  3. LF-3921d Use the server block for the root directive 

    I think the location blocks are only supposed to be used if there is a per location override
    @kathyavini
    kathyavini committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    21b8614 View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2023

  1. LF-3921d Add the try_file lines from the vite-pwa documentation 

    I had missed them initially and would like to include them for completeness. I saw no effect in my local testing
    @kathyavini
    kathyavini committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    604dae7 View commit details
    Browse the repository at this point in the history

  2. LF-3921d Restore the specific caching directives on webmanifest and s… 

    …w.js

I was able to repro locally all the bugs from the first PR with the root directive issue. These location blocks were not to blame
    @kathyavini
    kathyavini committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    44d66b4 View commit details
    Browse the repository at this point in the history