Lf 4015 hotfix routes #3081
Lf 4015 hotfix routes #3081
Conversation
Also remove orphan misnamed function from last commit
… of constant file
Also one missing add custom expense constant
Duncan-Brain
requested review from
antsgar and
kathyavini
and removed request for
a team
| @@ -0,0 +1,60 @@ | |||
| /* | |||
| * Copyright 2023 LiteFarm.org | |||
There was a problem hiding this comment.
2024! 😆
Thank you for working on this, I will start testing now!
There was a problem hiding this comment.
I'm surprised we didn't have more of that these last two weeks!
|
Looks good to me, at least on paper! I think we should merge it sooner rather than later to get more testing time on beta. Should we remove the deprecated routes file as part of this PR too? |
| @@ -901,7 +899,6 @@ const Routes = ({ isCompactSideMenu }) => { | |||
| /> | |||
| <Route path="/finances" component={Finances} /> | |||
There was a problem hiding this comment.
@antsgar Just noticed.. is this missing a /finances/* like the other one in this file?
| exact | ||
| component={ReadOnlyCustomRevenue} | ||
| /> | ||
| <Route | ||
| path="/finances/edit_custom_revenue/:revenue_type_id" | ||
| path={createEditCustomRevenueUrl(':revenue_type_id')} | ||
| exact | ||
| component={EditCustomRevenue} | ||
| /> |
There was a problem hiding this comment.
@antsgar The redirect below this line.. should it be redirecting from /finances to FINANCES_HOME_URL ?
There was a problem hiding this comment.
I'm not sure honestly, I think I copied that from similar files
@antsgar I see it as deleted 🤔 |
Description
Fixing finances routes.
Jira link:
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: