Include both pull_request and merge_group triggers #3104
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Alongside the recently merged Cypress PR #3100 we have set up a merge queue on integration. To my great sadness using the merge queue (
merge_group
workflow trigger) did not in fact trigger the GitHub workflow upon the most recent merge.This StackOverflow and the linked GitHub discussion suggest that -- as of July 2023 but the discussion has not been amended otherwise in the intervening months --
merge_group
on its own is insufficient; thepull_request
trigger must also be added and then filtered out.I have copied the example.
UPDATE: But I dislike that a notification is still sent/check is still listed for the filtered out job...!
Jira link: NONE
Type of change
How Has This Been Tested?
As it is a GitHub workflow trigger it's really hard to test without merging.
Checklist: