LF-4219: Create component for weight application rate tabs #3204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SayakaOno
force-pushed
the
LF-4219/Create_component_for_weight_application_rate_tabs
branch
from
e101944
to
7812d54
Compare
|
The design has changed, and this component is no longer necessary. Closing this pull request as it is no longer relevant. |
|
😢 Again! |
Duncan-Brain
reviewed
Jun 4, 2024
| import styles from '../styles.module.scss'; | ||
| import clsx from 'clsx'; | ||
|
|
||
| const VARIANTS = { | ||
| PILL: 'pill', | ||
| PLANE: 'plane', |
There was a problem hiding this comment.
"plain" 😄 not plane
Duncan-Brain
reviewed
Jun 4, 2024
|
I get this funny bug only in App (not in Storybook) on the exiting case of StateTabs only and not RouterTab; can you re-create it? It looks like a height bug on the non-focused tab?
|
|
Thank you for reviewing Duncan and Joyce!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
StateTabcomponent tovariant.Semiboldwithbuttonso that tabs become focusable. (I plan to use:focus-withinto style cards when focused, which will require this change. The outline is "none" for now.)RoterTabto be compatible with the new CSS.Jira link: https://lite-farm.atlassian.net/browse/LF-4219
Type of change
How Has This Been Tested?
Checklist: