Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Suggestion: rx #22

Closed
dazraf opened this issue May 27, 2017 · 2 comments
Closed

API Suggestion: rx #22

dazraf opened this issue May 27, 2017 · 2 comments

Comments

@dazraf
Copy link

dazraf commented May 27, 2017

Fantastic module, thanks!
I use the async version. The callbacks aren't composable / chainable.
So I've ended up writing extension methods wrapping all existing methods on MongoCollection, to return rx-java equivalents: Single, Observable.
Would be great if KMongo could provide similar.

@zigzago
Copy link
Member

zigzago commented May 27, 2017

I would prefer not to add a java-rx dependency on kmongo-async.
It would be nice to create a kmongo-async-rx subproject with the rx extensions methods.

Could you submit a PR, or send to me the extension methods you use?
Thanks

@dazraf
Copy link
Author

dazraf commented May 27, 2017

Good idea. Will share you my extensions and you can integrate into a new module if you like.

diliuskh added a commit to diliuskh/kmongo that referenced this issue Mar 26, 2018
zigzago pushed a commit that referenced this issue Mar 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants