Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix : perf issue with Class.forName with Kotlinx Datetime #416

Merged
merged 1 commit into from
May 17, 2023

Conversation

fhebuterne
Copy link
Contributor

Hi,

Since kmongo 4.7.2, performance has been degraded by Class.forName with kotlinx datetime during our requests to DB.

We not using kotlinx datetime lib, so Class.forName is call each time.

By using AsyncProfiler on wall mode, we can see it :

perf_issue_01

perf_issue_02

For an hotfix for us, we added kotlinx datetime to fix issue in our side, waiting a fix on KMongo.

I have added a fix on this PR, by loading Class.forName only on first time.

Could you check it, please 馃檹 ?

Sincerely,
Fabien

@zigzago
Copy link
Member

zigzago commented May 17, 2023

Thank you for the PR.

@zigzago zigzago merged commit c097555 into Litote:master May 17, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants