forked from spring-cloud/spring-cloud-netflix
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
set filters on RefreshablePeerEurekaNodes
fixes spring-cloudgh-3554
- Loading branch information
1 parent
c24e7e0
commit af8f8f0
Showing
4 changed files
with
173 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
39 changes: 39 additions & 0 deletions
39
...a/org/springframework/cloud/netflix/eureka/server/ReplicationClientAdditionalFilters.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| /* | ||
| * Copyright 2013-2019 the original author or authors. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * https://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.springframework.cloud.netflix.eureka.server; | ||
|
|
||
| import java.util.Collection; | ||
| import java.util.LinkedHashSet; | ||
|
|
||
| import com.sun.jersey.api.client.filter.ClientFilter; | ||
|
|
||
| /** | ||
| * @author Yuxin Bai | ||
| */ | ||
| public class ReplicationClientAdditionalFilters { | ||
|
|
||
| private Collection<ClientFilter> filters; | ||
|
|
||
| public ReplicationClientAdditionalFilters(Collection<ClientFilter> filters) { | ||
| this.filters = new LinkedHashSet<>(filters); | ||
| } | ||
|
|
||
| public Collection<ClientFilter> getFilters() { | ||
| return this.filters; | ||
| } | ||
|
|
||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
99 changes: 99 additions & 0 deletions
99
...amework/cloud/netflix/eureka/server/RefreshablePeerEurekaNodesWithCustomFiltersTests.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,99 @@ | ||
| /* | ||
| * Copyright 2013-2019 the original author or authors. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * https://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.springframework.cloud.netflix.eureka.server; | ||
|
|
||
| import java.lang.reflect.Field; | ||
| import java.util.Collections; | ||
|
|
||
| import com.netflix.eureka.cluster.PeerEurekaNodes; | ||
| import com.sun.jersey.api.client.ClientHandlerException; | ||
| import com.sun.jersey.api.client.ClientRequest; | ||
| import com.sun.jersey.api.client.ClientResponse; | ||
| import com.sun.jersey.api.client.filter.ClientFilter; | ||
| import org.junit.Test; | ||
| import org.junit.runner.RunWith; | ||
|
|
||
| import org.springframework.beans.factory.annotation.Autowired; | ||
| import org.springframework.boot.autoconfigure.EnableAutoConfiguration; | ||
| import org.springframework.boot.test.context.SpringBootTest; | ||
| import org.springframework.cloud.netflix.eureka.server.EurekaServerAutoConfiguration.RefreshablePeerEurekaNodes; | ||
| import org.springframework.context.annotation.Bean; | ||
| import org.springframework.context.annotation.Configuration; | ||
| import org.springframework.test.context.junit4.SpringRunner; | ||
| import org.springframework.util.ReflectionUtils; | ||
|
|
||
| import static org.assertj.core.api.Assertions.assertThat; | ||
|
|
||
| /** | ||
| * @author Yuxin Bai | ||
| */ | ||
| @RunWith(SpringRunner.class) | ||
| @SpringBootTest( | ||
| classes = RefreshablePeerEurekaNodesWithCustomFiltersTests.Application.class, | ||
| webEnvironment = SpringBootTest.WebEnvironment.RANDOM_PORT, | ||
| value = { "spring.application.name=eureka", "server.contextPath=/context", | ||
| "management.security.enabled=false" }) | ||
| public class RefreshablePeerEurekaNodesWithCustomFiltersTests { | ||
|
|
||
| @Autowired | ||
| private PeerEurekaNodes peerEurekaNodes; | ||
|
|
||
| @Test | ||
| public void testCustomPeerNodesShouldTakePrecedenceOverDefault() { | ||
| assertThat(peerEurekaNodes instanceof RefreshablePeerEurekaNodes) | ||
| .as("PeerEurekaNodes should be an instance of RefreshablePeerEurekaNodes") | ||
| .isTrue(); | ||
|
|
||
| ReplicationClientAdditionalFilters filters = getField(RefreshablePeerEurekaNodes.class, | ||
| (RefreshablePeerEurekaNodes) peerEurekaNodes, "replicationClientAdditionalFilters"); | ||
| assertThat(filters.getFilters()) | ||
| .as("PeerEurekaNodes'should have only one filter set on replicationClientAdditionalFilters") | ||
| .hasSize(1); | ||
| assertThat(filters.getFilters().iterator().next() instanceof Application.CustomClientFilter) | ||
| .as("The type of the filter should be CustomClientFilter as user declared so") | ||
| .isTrue(); | ||
| } | ||
|
|
||
| private static <T, R> R getField(Class<T> clazz, T target, String fieldName) { | ||
| Field field = ReflectionUtils.findField(clazz, fieldName); | ||
| ReflectionUtils.makeAccessible(field); | ||
| @SuppressWarnings("unchecked") | ||
| R value = (R) ReflectionUtils.getField(field, target); | ||
| return value; | ||
| } | ||
|
|
||
| @Configuration | ||
| @EnableAutoConfiguration | ||
| @EnableEurekaServer | ||
| protected static class Application { | ||
|
|
||
| @Bean | ||
| public ReplicationClientAdditionalFilters customFilters() { | ||
| return new ReplicationClientAdditionalFilters(Collections.singletonList(new CustomClientFilter())); | ||
| } | ||
|
|
||
| protected class CustomClientFilter extends ClientFilter { | ||
|
|
||
| @Override | ||
| public ClientResponse handle(ClientRequest cr) throws ClientHandlerException { | ||
| return getNext().handle(cr); | ||
| } | ||
| } | ||
| } | ||
|
|
||
|
|
||
| } |