New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

recursion warning in update.py #25

Open

2 tasks

BrandeisPatrick opened this issue Jan 4, 2023 · 0 comments

Assignees

Labels

invalid

Contributor

BrandeisPatrick commented Jan 4, 2023 •

edited

Loading

Warning 1

parts of update_solvent() is recursive
(this recursion could cause infinite loop, should be improved later)

Warning 2

the logic of execution of update_solvent() is unclear
(this part uses very complex if conditions, can be simplified later)

BrandeisPatrick added the invalid label

BrandeisPatrick self-assigned this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment