Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] MaterialKit causing leak #2

Closed
ApolloZhu opened this issue Oct 25, 2016 · 2 comments
Closed

[Enhancement] MaterialKit causing leak #2

ApolloZhu opened this issue Oct 25, 2016 · 2 comments

Comments

@ApolloZhu
Copy link
Contributor

MKTextField Leaking
Currently trying to fix this
Tried to add weak to these properties, does solve the problem, but causing the entire app to crash due to unknown reason
@LiulietLee
Copy link
Owner

Alright, I see. If we can't solve it, I will remove materialkit.

ApolloZhu added a commit to ApolloZhu/MaterialKit that referenced this issue Dec 20, 2016
@ApolloZhu
Remove all observed reference cycles/memory leaking
0454a44 
Finally able to solve? this: LiulietLee/Pick-Color#2
MKLayer’s superLayer observers
MKRefreshControl’s parentScrollView observers
MKSwitch’s parent MKSwitch

It’s sad that when containing MKLayer and MKRefreshControl, current
implementation requires calling `recycle` in `deinit`…
This was referenced Dec 20, 2016
Merged
Open
@LiulietLee
Copy link
Owner

Good job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@LiulietLee @ApolloZhu