Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize mod5 diffusion #31

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Optimize mod5 diffusion #31

wants to merge 1 commit into from

Conversation

jylee-bcm
Copy link

@jylee-bcm jylee-bcm commented Jul 5, 2024

This work is main branch version for one of optimization works done in nextflow branch.
It reduces the running time of 5 minutes for demo.vcf.gz on elpaso server, this running time may differ by your machine.
For more details, please refer the link to hyunhwan-bcm#9

  • Applied scalar multiplication to vector, not on matrix
  • Used indexing technique
  • Transformed from float64 to float32

Changed Output

There's subtle change on outputs, but I think they are ignorable.

>>> pd.testing.assert_series_equal(a["diffuse_Phrank_STRING"], b["diffuse_Phrank_STRING"])
Series values are different (0.04513 %)

@jylee-bcm jylee-bcm added the enhancement New feature or request label Jul 5, 2024
@jylee-bcm jylee-bcm self-assigned this Jul 5, 2024
Copy link
Contributor

@hyunhwan-bcm hyunhwan-bcm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants