Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Destack v3 #103

Merged
merged 119 commits into from Dec 16, 2023
Merged

Destack v3 #103

merged 119 commits into from Dec 16, 2023

Conversation

LiveDuo
Copy link
Owner

@LiveDuo LiveDuo commented Nov 9, 2023

Overview

This PR replaces Craft.js with a new vanilla editor. While the new editor is visually similar to the previous one it enables a few major changes to the project:

  • Store created pages in pure HTML
  • Minimal bundle size and a smaller codebase
  • Lay the foundation for various requested features (eg. custom js scripts, custom tailwind components, dynamic content and other requested features)

Beta Testing

The beta starter project on destack-starter-beta is updated for anyone willing to test the new version.

Tradeoffs

A major change with the new editor is that Destack no longer uses a custom JSON format to store the user generated pages and uses pure HTML instead. Besides the many benefits and significant reduction in complexity not having React based components comes with a tradeoff in flexibility. If not handle properly, more flexibility could be dangerous as uncle Ben said. For example, someone might use the editor in a user facing application not realising that there's no XSS validation by default.

Another tradeoff is that it's harder to implement state management with the vanilla editor. This is not generally a problem as HTML acts as the state but there are a few cases that state management is useful. For example, state diffs required by Undo/Redo are easier to handle in JSON files than HTML files that are plain text.

Moving forward

  • Wait a few days/weeks for people to test out the new beta version
  • Enable tree shaking to reduce bundle size and loading time

@LiveDuo LiveDuo merged commit ecebe41 into main Dec 16, 2023
1 check passed
@LiveDuo LiveDuo deleted the feature/vanilla branch December 16, 2023 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant