Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Widget stuck to send messages #1

Closed
eodin opened this issue Sep 26, 2014 · 4 comments
Closed

Widget stuck to send messages #1

eodin opened this issue Sep 26, 2014 · 4 comments

Comments

@eodin
Copy link

eodin commented Sep 26, 2014

I've tested NodeJS connection durability and found the issue. Once NodeJS process died on server widget can't push messages anymore until operator's message will be received. Even after nodejs restart it still work one-way.

visitor: hello
operator: hello. can I help you?

[socket.io.js terminated]

visitor: I have major issue
visitor: when I'm trying to login my account I see other's name and balance
visitor: I even able to withdraw his money

[socket.io.js restored]

visitor: Any comment?
visitor: operator are you there?
operator: what's the problem? (just getting prev messages)
visitor: WTF

@remdex
Copy link
Contributor

remdex commented Sep 26, 2014

Sorry, but it's not enough steps to reproduce... Why does NodeJS died?
If i correctlu understood your test workflow was:

  1. Shutdown nodejs
  2. Wait untill connection is closed.
  3. Turn on NodeJS, after that even if users connects they cannot chat

Is that the case you are trying to describe?

@eodin
Copy link
Author

eodin commented Sep 26, 2014

Almost. I've tested that happens with alive session during nodejs restart for example

  1. open chat http://chat/
  2. accept operator chat at http://chat/site_admin/
  3. shutdown nodejs
  4. test chat still work but only one-way now
  5. run nodejs again
    5 . make sure what widget switched back to nodejs but still works if only operator send a message

@remdex
Copy link
Contributor

remdex commented Sep 26, 2014

That's more detailed report:) I'l see what i can do about that :)

remdex added a commit that referenced this issue Sep 26, 2014
…t NodeJs is dead and restores to nodejs protocol automatically if it reconnects
@remdex
Copy link
Contributor

remdex commented Sep 26, 2014

Implemented.

@remdex remdex closed this as completed Sep 26, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants