Customize Delta text #9
Conversation
Added options to change the text on the left of the component. Added an extra option to display different texts when ahead or behind the comparison.
| InternalComponent.AlternateNameText.Clear(); | ||
| InternalComponent.AlternateNameText.Add(CompositeComparisons.GetShortComparisonName(comparison)); | ||
| } | ||
| InternalComponent.LongestString = text; |
There was a problem hiding this comment.
This needs to be the longest possible string out of all the values it can switch between, otherwise the horizontal layout will resize when the text changes.
There was a problem hiding this comment.
Specifically, I think it needs to be the longer of Settings.CustomText and Settings.CustomTextAhead when there's an override
There was a problem hiding this comment.
I can write it like that, though the old behaviour (when set to Current Comparison) was to update LongestString to the (current) long comparison name at each update, not the longest it can be without changing the settings.
If this variable is meant to be changed while running (previously it was at each current comparison change), I don't see the point of telling the renderer to make space for something longer than we need it to display.
If it's not meant to be changed regularly, would it be better to set it to the longest comparison name when set to current comparison ?
Or is it a kind of "middle ground", meaning changing comparison is meant to be relatively rare and at that point changing layout spacing isn't a big deal, while being ahead/behind changes often enough to warrant always making enough space for both texts ?
There was a problem hiding this comment.
The issue with your current code is that the text changes between ahead vs. behind, but LongestString doesn't account for this. That's the only case that's problematic in my opinion.
Changing the comparison or the settings isn't something we need to account for here
(ideally changing the comparison wouldn't cause a resize either, but since that's already an issue outside of this PR, no need to handle it)
Fixed the counter-intuitive behaviour of still providing the short comparison name as an alternate text when using custom text. Also fixes LongestString not necessarily being the longest alternative
Renamed labels used in the code. Renamed TextBehind/TextAhead to CustomText/CustomTextAhead to better express the fact that the first one is used as the sole text in constant text mode and as the text when behind otherwise.
|
Last 2 commits fix issues pointd earlier. |
In differential mode, LongestString is now always the longest of the two strings, to avoid causing resizings.
Parent PR: LiveSplit/LiveSplit#2497
Added options to customize the text on the left of the component.