You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
A streamer working on a "Best Pace Since" component, which shows a relative timestamp/date, noticed that times loaded from the splits file were undergoing a local->UTC timezone conversion while attempts done with the timer open were not, leading to inconsistencies in the output.
The timestamp we're getting back from livesplit-core already have the time zone info as UTC. The issue is that we're not converting to UTC with ToUniversalTime()
Until the fix for this is released, in the "Best Pace Since" component, you can just call ToUniversalTime() on the AttemptStarted and AttemptEnded timestamps to get them all into UTC
A streamer working on a "Best Pace Since" component, which shows a relative timestamp/date, noticed that times loaded from the splits file were undergoing a local->UTC timezone conversion while attempts done with the timer open were not, leading to inconsistencies in the output.
I assume this
DateTime.Parse()
, whichis missing theleaves theDateTimeStyles.AssumeUniversal
argument andDateTime.Kind
asUnspecified
Local
, causes the problem:https://github.com/LiveSplit/LiveSplit/blob/master/LiveSplit/LiveSplit.Core/Model/RunFactories/StandardFormatsRunFactory.cs#L51
I'd open a PR, but I do not have a windows environment set up, and have no good way of testing for regressions at the moment.
The text was updated successfully, but these errors were encountered: