Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Taking ownership of the FEZ autosplitter #1135

Merged
merged 2 commits into from Aug 30, 2018
Merged

Taking ownership of the FEZ autosplitter #1135

merged 2 commits into from Aug 30, 2018

Conversation

jbzdarkid
Copy link
Contributor

CryZe
CryZe reviewed Jul 21, 2018
View reviewed changes
LiveSplit.AutoSplitters.xml Outdated
<AutoSplitter>
<Games>
<Game>FEZ</Game>
<Game>Fez</Game>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Game Names are case insensitive, so you have a duplicate name here.

@CryZe
Copy link
Contributor

CryZe commented Jul 21, 2018 •
edited

Also I'd like to see some confirmation by the original author that they are okay with this ownership transfer, before merging this.

@Spiraster
Copy link
Contributor

I'm OK with the transfer

@wooferzfg wooferzfg added the autosplitter A PR to update the LiveSplit.AutoSplitters.xml file, before it was moved to a separate repository. label Aug 30, 2018
@wooferzfg wooferzfg merged commit ce115de into LiveSplit:master Aug 30, 2018
@jbzdarkid jbzdarkid deleted the patch-1 branch September 1, 2018 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CryZe CryZe CryZe left review comments

Assignees
No one assigned
Labels
autosplitter A PR to update the LiveSplit.AutoSplitters.xml file, before it was moved to a separate repository.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jbzdarkid @CryZe @Spiraster @wooferzfg