Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ARM macOS target to CI #382

Merged
merged 5 commits into from
Mar 17, 2021
Merged

Add ARM macOS target to CI #382

merged 5 commits into from
Mar 17, 2021

Conversation

CryZe
Copy link
Collaborator

@CryZe CryZe commented Dec 31, 2020

Rust 1.49 just released with support for the new macs that use ARM CPUs. Let's add this to our CI.

@CryZe CryZe added enhancement An improvement for livesplit-core. ci Affects the Continuous Integration. labels Dec 31, 2020
@CryZe CryZe requested a review from wooferzfg December 31, 2020 14:57
@CryZe
Copy link
Collaborator Author

CryZe commented Dec 31, 2020

Alright, that's a green build. Unfortunately it seems like GitHub Actions neither has any ARM nodes nor does it have very many BigSur / macOS 11 nodes, meaning that it takes a lot of time for those nodes to boot up. Not sure if we should maybe wait a bit before we merge this, as it just doesn't seem like it's super ready on GitHub's side.

@CryZe
Copy link
Collaborator Author

CryZe commented Jan 27, 2021

They are tracking performance here: actions/runner-images#2486
And native ARM support here: actions/runner-images#2187

@CryZe CryZe added the blocked Progress is blocked and can't progress. label Jan 27, 2021
Rust 1.49 just released with support for the new macs that use ARM CPUs. Let's add this to our CI.
The toolchain obviously won't run on x86_64 macOS that GitHub Actions is running on. Let's try cross compiling instead.
We need to install the target and since we cross compile without cross, we can't run any tests either.
Apparently when they mean latest, they don't actually mean that.
Embark seems to use xcode-select on GitHub Actions to switch to a newer
version of XCode instead of switching the macOS version itself:

https://twitter.com/Ca1ne/status/1372120481147535363
@CryZe CryZe removed the blocked Progress is blocked and can't progress. label Mar 17, 2021
@CryZe CryZe merged commit 9f53731 into master Mar 17, 2021
@CryZe CryZe deleted the CryZe-patch-1 branch March 17, 2021 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Affects the Continuous Integration. enhancement An improvement for livesplit-core.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant