[zAdd] #26
[zAdd] #26
Conversation
|
I'm not following. Could you please elaborate? What's the issue? |
|
Oh right, I see what you mean. The I added a few comments, please review. Good catch! |
| case class ZAdd[W](key: String, members: Map[W, scredis.Score])( | ||
| implicit writer: Writer[W] | ||
| ) extends Request[Long]( | ||
| ) extends Request[Long]( |
There was a problem hiding this comment.
I see an indentation issue here.
newline problem
|
I reviewed my code and removed all difference not necessary. Thank you for taking time to look my work |
| client.zRangeWithScores( | ||
| "SET" | ||
| ).futureValue should contain theSameElementsInOrderAs List[(String, Score)]( | ||
| ("D", -2.6), ("C", -1.3), ("A", 2.5), ("B", 3.8) | ||
| ("D", -2.6), ("E", -2.6), ("C", -1.3), ("A", 2.5), ("B", 3.8) |
There was a problem hiding this comment.
Do we have any guarantee from Redis that D will appear before E? If not then we should account for that in the test case and allow them to switch place.
There was a problem hiding this comment.
The elements having the same score are returned in lexicographical order.
|
Looks good. I just have a small concern for the test case, please check my comment. |
|
All good. Will include in the next minor release. Thank you for contributing. |
Fixed an issue in the implementation of the zAdd request which prevented multiple members with identical scores to be added.
zAdd with map with members has same score