Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: fruit bar #80

Merged
merged 6 commits into from
Jun 25, 2023
Merged

feat: fruit bar #80

merged 6 commits into from
Jun 25, 2023

Conversation

FranckG28
Copy link
Collaborator

Closes #70

@FranckG28 FranckG28 self-assigned this Jun 19, 2023
jvondermarck
jvondermarck requested changes Jun 20, 2023
View reviewed changes
Copy link
Member

@jvondermarck jvondermarck left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hii mon petit chacra d'amour...

cancel

Changes to make :

⚠️ You should just change the fruit bar display direction from left-->right to right-->leftas the real Pac-Man arcade game.

Here a screenshot on how it should look like :

image

I suggested you some change to make your life easier with a code that should work ! Great work otherwise, thanksss !!
like

src/ui/game_info_panel.c Outdated Show resolved Hide resolved
src/ui/game_info_panel.c Show resolved Hide resolved
@jvondermarck
fix(game-window): continue to display the game info panel (score, num…
8affe8e 
…ber of lives, ...) when next round animation is running
@jvondermarck
Copy link
Member

If u accept my suggestions... u will deserve a walk to walk.. 🤫

@FranckG28
Copy link
Collaborator Author

i'm ready to deguste your walk to walk

jvondermarck
jvondermarck requested changes Jun 25, 2023
View reviewed changes
Copy link
Member

@jvondermarck jvondermarck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's wrong, you didn't read my code suggestion ...
image

@jvondermarck jvondermarck merged commit 7d74fc2 into main Jun 25, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jvondermarck jvondermarck jvondermarck requested changes

Assignees

@FranckG28 FranckG28

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Level progression bar
2 participants
@FranckG28 @jvondermarck