Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

synergy: Add module for client and server #99

Merged
merged 2 commits into from
Sep 14, 2018

Conversation

Enzime
Copy link
Collaborator

@Enzime Enzime commented Sep 11, 2018

No description provided.

Copy link
Owner

@LnL7 LnL7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also add a basic test. It doesn't have to check much but having a test that enables the options will verify that it evaluates atleast.

'';
};
configFile = mkOption {
default = "/etc/synergy-server.conf";
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason not to manage this with nix?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just trying to mirror the nixpkgs options

services.synergy = {
client = {
enable = mkOption {
default = false;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing a type, same with a bunch of other options. Most of those are probably types.str.

@LnL7
Copy link
Owner

LnL7 commented Sep 14, 2018

I fixed the nix 2.0 -> 2.1 installer issue.

Copy link
Owner

@LnL7 LnL7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@LnL7 LnL7 merged commit c493114 into LnL7:master Sep 14, 2018
@Enzime Enzime deleted the add/synergy-service branch February 4, 2022 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants