-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
synergy: Add module for client and server #99
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you also add a basic test. It doesn't have to check much but having a test that enables the options will verify that it evaluates atleast.
''; | ||
}; | ||
configFile = mkOption { | ||
default = "/etc/synergy-server.conf"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason not to manage this with nix?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just trying to mirror the nixpkgs options
modules/services/synergy/default.nix
Outdated
services.synergy = { | ||
client = { | ||
enable = mkOption { | ||
default = false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing a type, same with a bunch of other options. Most of those are probably types.str
.
e00291d
to
32d7297
Compare
I fixed the nix 2.0 -> 2.1 installer issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
No description provided.