Add script to quickly set up a build slave using Docker #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3noch
commented
Feb 22, 2017
start-docker-nix-build-slave
Outdated
| echo ">>> Downloading SSH credentials for the docker machine" | ||
| rm -f "$ssh_id_file" "$ssh_id_file.pub" | ||
| curl https://raw.githubusercontent.com/LnL7/nix-docker/master/ssh/insecure_rsa > "$ssh_id_file" | ||
| curl https://raw.githubusercontent.com/LnL7/nix-docker/master/ssh/insecure_rsa.pub > "$ssh_id_file.pub" |
There was a problem hiding this comment.
Since this is part of the repo, it could conceivably use these from the local repo. However, as is, this script can be downloaded with curl and run. That might be a pretty desirable feature.
There was a problem hiding this comment.
I guess that depends on how this would be used, this has the advantage that people don't need to have the entire repository locally.
LnL7
reviewed
Feb 22, 2017
start-docker-nix-build-slave
Outdated
| echo "## Usage: source $0" | ||
| echo "##" | ||
| echo "## Note: if you experience issues, you can clean up the build slave artifacts and start over by:" | ||
| echo "## 1. rm -r ~./$working_dir_name" |
start-docker-nix-build-slave
Outdated
| # -- Download SSH credentials for docker machine -- | ||
| echo ">>> Downloading SSH credentials for the docker machine" | ||
| rm -f "$ssh_id_file" "$ssh_id_file.pub" | ||
| curl https://raw.githubusercontent.com/LnL7/nix-docker/master/ssh/insecure_rsa > "$ssh_id_file" |
There was a problem hiding this comment.
Using curl -fsSL <url> -o <file> will hide the curl output if nothing fails (downloading shouldn't take long)
There was a problem hiding this comment.
Great idea. I'll add that.
|
I made those changes and rebased. |
|
Indeed, this actually works, which is pretty neat: source <(curl https://raw.githubusercontent.com/grafted-in/nix-docker/build-slave-script/start-docker-nix-build-slave) |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm sure there's a lot of room for improvement, but it's a start. I'm happy to make changes.