-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes to --list and more #52
Conversation
so as for the man pages for list_devices_* i made those a symlink to list_devices is that not something we can do here? if not we may as well drop the alias as there is no point in maintaining 3 copies of the same file |
Does flake8 complain about this?
|
you said you liked commas in the
|
Fix copy/paste mistake:
|
I did not receive any symlink files in the zip archive. We can just leave them as copies, which is easier to track on git anyway. |
It does indeed complain, as it violates PEP8:
|
guess it just followed the links
|
I just noticed that the changes in this pull request break the Reference output on master (Settings to red first and then setting to automatic afterwards, which works):
Output on this branch (Settings to red first and then setting to automatic afterwards, which does not work and red remains):
|
What is is doing it pulling the existing color from the mouse via, see man page for color, line 8 - 11 |
I understand what the man page for I'd like the |
Here are some options
Use X color for
|
I'll let you update the color manual to mention that X color will be used if you use |
|
revised patch using -a will set brightness to 100% (if you do not define a effect, brightness, or set multiple zones (logo,wheel = 1 zone & logo wheel = 2 zones) |
These latest changes work for me. |
If you have a settings file that causes a key error or anything i can get a copy of it?
this has 2 patches, each handle --restore differently
|
I don't have a copy of my old settings file. Which patch does what? I can't tell. They're called: settings-brightness_superior.patch
settings-effect_brightness_superior.patch # I assume this is the one that removes brightness as an effect? I can't tell the diff contents apart either, as they include partly the same changes. |
Regarding the
|
x_color_2_util.patch.zip |
What does that mean?
Is this patch based on the previous two you uploaded or does it include the changes of one? Or is it completely independent? Please just give me one patch that is based on the latest changes in this PR, that includes everything you still want to add. I don't care at this point which of the brightness options or whatever is used, I just want this to be merged. If it makes any difference, I'd prefer it if |
that last one is independent (applied after either of the last 2) settings-brightness_superior.patch and settings-effect_brightness_superior.patch only affect the --restore option lets say you did this:
settings-brightness_superior.patch settings-effect_brightness_superior.patch As it currently is the settings-effect_brightness_superior.patch moves NO patch has removed |
Personally i think the current implementation of save/load settings is quite poor, admittedly it is better than when i started messing with it, i think the entire structure of the settings file should be changed to allow a proper was to keep track of what was set to what zone, the current save was not designed to keep track of stacked commands each targeting different zones of the hardware |
Ah that makes sense to me now, thanks. I falsely assumed the If you wanna give the whole settings functionality an overhaul feel free to do so, but let's merge this PR first. I'll add your latest changes to it tomorrow, probably, as I don't have the code repository with me right now. |
no plans of stating that today, maybe next week or when ever i feel like it, but if i do i am creating a new setting file(s) and it will not touch the old one it can sit in the folder till the user deletes it manually incase they want to read it |
I couldn't apply the last patch you uploaded here, because something changed after applying the previous patches, I assume.
So I manually copied each change into the code. This is getting unbearably tedious. After this pull request I will most likely not accept any more changes from contributors that do not come in a pull request directly from them. I appreciate every contribution, but dealing with them like this is not worth it. |
@GM-Script-Writer-62850 Please look through the changes of the pull request once more and test everything yourself, if everything is working we can merge it. |
I did notice one other very minor change we can make |
That seems like such a minuscule performance improvement, I wouldn't bother. I'd say we merge it. |
Regarding #51