Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Will there be more language support? #2

Closed
zixzaxlad opened this issue May 22, 2023 · 9 comments
Closed

Will there be more language support? #2

zixzaxlad opened this issue May 22, 2023 · 9 comments

Comments

@zixzaxlad
Copy link
Contributor

This software looks truly amazing!
Unfortunately, Chinese characters do not seem to be supported. Will there be Unicode support for Chinese/Japanese/Korean? Unicode should be the most universal solution for Chinese characters/Kanji (though I'm not certain, just did a quick search).
Is there any chance we can get Chinese character support?
Great software nonetheless, I really appreciate it.

@LoadingByte
Copy link
Owner

All writing systems are supported, even right-to-left text is correctly handled (and even when mixing LTR and RTL sections). However, you need a font that supports the characters you use. For example, the fonts that are shipped with Cinecred don't support Chinese characters. However, when selecting a font that does (e.g., Noto Sans CJK SC), Chinese text is correctly rendered:

image

@zixzaxlad
Copy link
Contributor Author

zixzaxlad commented May 22, 2023 via email

@LoadingByte
Copy link
Owner

Funnily enough, another user actually already translated Cinecred into Chinese, and this will ship in the next release. But thanks a lot for your offer!

@zixzaxlad
Copy link
Contributor Author

zixzaxlad commented May 22, 2023 via email

@LoadingByte
Copy link
Owner

Just a quick thought... would you maybe be willing to double-check the translation? As I can't read Chinese myself, I'd be very grateful for someone to make sure that the translation is indeed accurate.

If you are open for this, just email me at felix At cinecred Dot com, and we'll talk about the details.

@zixzaxlad
Copy link
Contributor Author

a small issue related to Chinese
Whenever I render a file with a Chinese character the software will crash.

@LoadingByte
Copy link
Owner

I just tried it and it doesn't crash for me. Could you maybe elaborate on what exactly you did, and, if possible, include the credits and styling files from your project folder?

@zixzaxlad
Copy link
Contributor Author

zixzaxlad commented May 28, 2023 via email

@LoadingByte
Copy link
Owner

Alright, I managed to reproduce the crash—it happens on Windows only, it seems—when rendering a video whose filename contains non-ASCII characters. This was because for some reason, strings were not encoded as UTF-8 but something else when being passed to FFmpeg, but only on Windows.

I'm now forcing UTF-8 encoding, and this has fixed the issue. The fix will ship in the next release; until then, you have to use ASCII characters only as a workaround when exporting video files. Thanks for your report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants