You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Actual Behavior
The fresh sheet email and newsletter email are still being sent to users whose organizations have yet to be activated or were deactivated intentionally.
Repro 1
Market manager clicks on Market Info tab, unchecks Auto-activate organizations and saves
If market manager sends fresh sheet or newsletter at this point, this confirmed-but-inactive user will receive the emails
Repro 2
As market manager, find an existing active organization with a non-suspended user that just belongs to that org
Click Deactivate button
Send a fresh sheet and newsletter
User will receive emails
Expected
We should not send fresh sheet nor newsletter to any users of inactive organizations (organization.active). Remember a user could belong to multiple organizations (one that is inactive, one that is active) so a user should still receive an email if part of an active org and inactive org.
An organization may be inactive due to the following:
a user/org has registered, confirmed their email, but is still waiting to be activated by market manager (for markets that have Auto-activate organizations disabled on their Market Info tab)
a market manager intentionally deactivated an org by clicking Deactivate on /admin/organizations or /admin/organizations/1234
Notes
There was an attempted fix in Lo 808 fix email receiver filter #3284 but it doesn't seem to have resulted in the expected results above. Rob accidentally released the PR 5.0.11 so it didn't get properly tested on staging nor was the issue well defined. These scenarios are working correctly, however:
if organization is active but a user has been "suspended" from that organization — by clicking Suspend button on /admin/organizations/1234/users (user_organizations.enabled)
if user hasn't confirmed their email address yet (user.confirmed?)
rbarreca
changed the title
Fresh sheet and Newsletter being sent to unactivated accounts
Fresh sheet and Newsletter being sent to users in inactive organizations
Jul 25, 2018
Actual Behavior
The fresh sheet email and newsletter email are still being sent to users whose organizations have yet to be activated or were deactivated intentionally.
Repro 1
Auto-activate organizations
and savesuser.confirmed?
should be true, butorganization.active?
false still)Repro 2
Deactivate
buttonExpected
We should not send fresh sheet nor newsletter to any users of inactive organizations (
organization.active
). Remember a user could belong to multiple organizations (one that is inactive, one that is active) so a user should still receive an email if part of an active org and inactive org.An organization may be inactive due to the following:
Auto-activate organizations
disabled on their Market Info tab)Deactivate
on/admin/organizations
or/admin/organizations/1234
Notes
Suspend
button on/admin/organizations/1234/users
(user_organizations.enabled
)user.confirmed?
)[JIRA Import Details]
Issue URL: https://localorbit.atlassian.net/browse/LO-808
Reporter: Kate Barker
Issue Type: Bug
The text was updated successfully, but these errors were encountered: