Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating for node v0.6 #533

Merged
merged 16 commits into from Feb 3, 2012
Merged

Updating for node v0.6 #533

merged 16 commits into from Feb 3, 2012

Conversation

quartzjer
Copy link
Member

There weren't many changes in the core codebase, but this also updates all the major packages to the 0.6+ versions, so it's a pretty significant and comprehensive step forward that needs more testing.

The tests don't pass yet, but they run, so more help is needed!

@quartzjer
Copy link
Member Author

I was able to just run this cleanly, yay!

@aflatter
Copy link

Yup, my locker runs fine too. :)

@quartzjer quartzjer mentioned this pull request Jan 31, 2012
@mdz
Copy link
Member

mdz commented Feb 2, 2012

Not working for me:

[dashboardv3] The "sys" module is now called "util". It should have a similar interface.
[dashboardv3]
[dashboardv3] /home/mdz/src/singly/Locker/Common/node/lconfig.js:20
[dashboardv3] throw err;
[dashboardv3] ^
[dashboardv3] Error: ENOENT, no such file or directory '../../Config/config.json'

@mdz
Copy link
Member

mdz commented Feb 2, 2012

Sorry, wasn't up to date. temas' changes fixed this I think

@mdz
Copy link
Member

mdz commented Feb 2, 2012

Scratch that, it's still happening

@mdz
Copy link
Member

mdz commented Feb 2, 2012

Looks like it's related to my Me/ directory being a symlink. Worked fine on master/0.4 for a long time, but breaks on v6/0.6.9

@mdz
Copy link
Member

mdz commented Feb 3, 2012

Test suite doesn't run at all for me:

tutti:[~/src/singly/Locker/tests] node runTests.js
Locker did not start correctly, got the error: Error: Cannot find module 'lutil'

@temas
Copy link
Member

temas commented Feb 3, 2012

Best testing I could get from everyone would be to do the following:

  • Checkout the v6 branch
  • rm -rf node_modules
  • npm install
  • Verify your locker runs in a way you wish
  • npm test
  • Verify all tests pass

@mdz
Copy link
Member

mdz commented Feb 3, 2012

Don't forget step 0. upgrade to node v0.6. :-)

On Fri, Feb 03, 2012 at 11:39:38AM -0800, Thomas Muldowney wrote:

Best testing I could get from everyone would be to do the following:

  • Checkout the v6 branch
  • rm -rf node_modules
  • npm install
  • Verify your locker runs in a way you wish
  • npm test
  • Verify all tests pass

Reply to this email directly or view it on GitHub:
#533 (comment)

  • mdz

temas pushed a commit that referenced this pull request Feb 3, 2012
@temas temas merged commit 1c3182f into master Feb 3, 2012
@clemsos clemsos mentioned this pull request Sep 13, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants