Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generated 2022 week 4 schema #7

Merged
merged 12 commits into from
Jan 31, 2022
Merged

Generated 2022 week 4 schema #7

merged 12 commits into from
Jan 31, 2022

Conversation

tspence
Copy link
Contributor

@tspence tspence commented Jan 28, 2022

Key changes:

  • Better nullability for parameters
  • Cleaned up LockstepApi file

@tspence
Copy link
Contributor Author

tspence commented Jan 31, 2022

More changes:

  • Switched the build process to use rollup
  • Set up imports in the index.ts file so that all objects are included
  • Fixed an issue where the type "File" was not valid - switched it to a Uint8Array.
  • Corrected imports of OS and URL using NodeJS types
  • Compiled the program down to a single file - lockstep-api.js
  • Included a sourcemap and a .d.ts file
  • Created a proper "npm run build" task
  • Fixed some configuration options in tsconfig.json
  • Switcfhed ErrorResult to be a class rather than a type
  • Code generator now emits the new patterns
  • According to ESLint, we prefer doublequotes rather than singlequotes, so switched to those

@dhric
Copy link
Contributor

dhric commented Jan 31, 2022

Reviewed with Ted on the use of Rollup.js.

@dhric dhric closed this Jan 31, 2022
@dhric dhric reopened this Jan 31, 2022
@tspence
Copy link
Contributor Author

tspence commented Jan 31, 2022

Per @dhric 's approval, landing!

@tspence tspence merged commit 1821d8f into Lockstep-Network:main Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants