removed overlap of text and icon in input box & refactored input-base #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
NicholasLin718
commented
Feb 3, 2023
•
NicholasLin718
commented
- Modified tailwind styling to allow icons to exist without overlap with the input
- Modified input-base into smaller reusable tailwind class components
✅ Deploy Preview for lodestone-dashboard ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
3 tasks
Ynng
requested changes
Feb 3, 2023
| @@ -253,10 +249,10 @@ export default function InputBox({ | |||
| placeholder={placeholder} | |||
| onChange={onChange} | |||
| maxLength={maxLength} | |||
| className={`input-base w-full ${ | |||
| className={`input-base w-full ${icons.length ? 'pr-16' : 'pr-4'} ${ | |||
There was a problem hiding this comment.
Try to set the right padding dynamically based on the length of the icon list?
Since it might be 1 or 3
Here's a quick example
NicholasLin718
changed the title
Closed
4 tasks
NicholasLin718
changed the title
Ynng
pushed a commit
that referenced
this pull request
Jul 14, 2023
make vendored openssl build optional via a feature flag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.