Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ToastContainer to set icons in toasts based on toast type #150

Merged
merged 2 commits into from
Feb 12, 2023

Conversation

kevinzhangTT
Copy link
Member

Implemented a renderIcon function that returns the appropriate toast type for the corresponding IconProps.type passed in. Now, the icon prop in the ToastContainer component uses the renderIcon function.

There is no success toast however, since level does not accept 'Success'. The default toast type is the info toast.

#110

@netlify
Copy link

netlify bot commented Feb 12, 2023

Deploy Preview for lodestone-dashboard ready!

Name Link
🔨 Latest commit fbd6c38
🔍 Latest deploy log https://app.netlify.com/sites/lodestone-dashboard/deploys/63e8817075acbc0008409f93
😎 Deploy Preview https://deploy-preview-150--lodestone-dashboard.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Feb 12, 2023

Deploy Preview for lodestone-storybook ready!

Name Link
🔨 Latest commit fbd6c38
🔍 Latest deploy log https://app.netlify.com/sites/lodestone-storybook/deploys/63e881705ca5060008e6870f
😎 Deploy Preview https://deploy-preview-150--lodestone-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@Ynng Ynng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@kevinzhangTT kevinzhangTT merged commit c5da15f into 0.4.2 Feb 12, 2023
@kevinzhangTT kevinzhangTT deleted the 0.4.1-toast-type branch February 12, 2023 06:27
@kevinzhangTT
Copy link
Member Author

Just for the record: the branch was named incorrectly. It should have been 0.4.2-toast-type instead of 0.4.1-toast-type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants