Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Left Navbar implementation #152

Merged
merged 29 commits into from
Feb 18, 2023
Merged

Left Navbar implementation #152

merged 29 commits into from
Feb 18, 2023

Conversation

NicholasLin718
Copy link
Contributor

@NicholasLin718 NicholasLin718 commented Feb 14, 2023

  1. Moved User Login/Core settings to the left navbar
  2. Created a new IconButton used for core setting and power on/off of a selected instance
  3. Instance information is now displayed on the left navbar above the instance tabs
  4. Instance tabs moved to the left navbar, and introduced new routes under /dashboard/{tab_name}. The new default is dashboard/overview
  5. New styling for displaying all instances

*Currently, the navbar and user login dropdown have hardcoded widths and will require investigation to determine how we can truncate the username whilst using dynamic width.

@netlify
Copy link

netlify bot commented Feb 14, 2023

Deploy Preview for lodestone-dashboard ready!

Name Link
🔨 Latest commit 5cba268
🔍 Latest deploy log https://app.netlify.com/sites/lodestone-dashboard/deploys/63f129d03bec4d000825f3c9
😎 Deploy Preview https://deploy-preview-152--lodestone-dashboard.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Feb 14, 2023

Deploy Preview for lodestone-storybook ready!

Name Link
🔨 Latest commit 5cba268
🔍 Latest deploy log https://app.netlify.com/sites/lodestone-storybook/deploys/63f129d0dfeaa400089071ba
😎 Deploy Preview https://deploy-preview-152--lodestone-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

src/components/DashboardLayout/InstanceViewLayout.tsx Outdated Show resolved Hide resolved
src/components/DashboardLayout/InstanceNestedBarStates.tsx Outdated Show resolved Hide resolved
src/components/DashboardLayout/LeftNav.tsx Outdated Show resolved Hide resolved
src/pages/InstanceTabs/InstanceTabs.tsx Outdated Show resolved Hide resolved
src/components/DashboardLayout/LeftNav.tsx Show resolved Hide resolved
src/components/DashboardLayout/SettingsLayout.tsx Outdated Show resolved Hide resolved
Copy link
Member

@Ynng Ynng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left nav scrolling is still broken ish,
the buttons in the left nav is missing the blue glowing border on tab
and this:
image

Copy link
Member

@Ynng Ynng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • The "power" button doesn't have keybaord focus border
  • the "power" button isn't really a square?
  • Scrolling behavior of the left nav is still not perfect
  • When I change instant, the tab jumps back to /overview, can we keep the current tab

Copy link
Member

@Ynng Ynng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • The restart button does not have tooltip
  • The spacing is different between the restart <-> power button, and user dropdown <-> gear icon

image

Copy link
Member

@Ynng Ynng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants