Merge 5065a4c into 50db849

lib/dotloop.rb

@@ -16,6 +16,7 @@
 require 'dotloop/participant'
 require 'dotloop/person'
 require 'dotloop/task'
+require 'dotloop/exceptions'
 
 require 'dotloop/models/document'
 require 'dotloop/models/document_activity'

lib/dotloop/client.rb

@@ -20,10 +20,22 @@ def get(page, params = {})
 
     def raw(page, params = {})
       response = self.class.get(page, query: params, headers: headers, timeout: 60)
-      raise "Error communicating: Response code #{response.code}" unless response.code == 200
+      handle_dotloop_error(response.code) if response.code != 200
       response.parsed_response
     end
 
+    def handle_dotloop_error(response_code)
+      error = case response_code
+              when 401
+                Dotloop::Unauthorized
+              when 403
+                Dotloop::Forbidden
+              else
+                StandardError
+              end
+      raise error, "Error communicating: Response code #{response_code}"
+    end
+
     def Profile
       @profile ||= Dotloop::Profile.new(client: self)
     end

lib/dotloop/exceptions.rb

@@ -0,0 +1,4 @@
+module Dotloop
+  class Forbidden < StandardError; end
+  class Unauthorized < StandardError; end
+end

lib/dotloop/section.rb

@@ -1,10 +1,10 @@
 module Dotloop
   class Section
     attr_accessor :sections
-    FIXED_SECTIONS = %i(
+    FIXED_SECTIONS = %i[
       contract_dates contract_info financials geographic_description listing_information
       offer_dates property_address property referral
-    ).freeze
+    ].freeze
 
     def initialize(data)
       @sections = FIXED_SECTIONS.each_with_object({}) { |key, memo| memo[key] = {} }.merge(contacts: [])

spec/dotloop/client_spec.rb

@@ -1,5 +1,6 @@
 require_relative '../spec_helper'
 
+# rubocop:disable Metrics/BlockLength
 RSpec.describe Dotloop::Client do
   let(:api_key) { 'blah' }
   let(:application) { 'bloh' }
@@ -53,7 +54,23 @@
       let(:code) { 234 }
       it 'should raise an error if the response code is not 200' do
         expect(subject.class).to receive(:get).with('foo', anything).and_return(response)
-        expect { subject.get('foo') }.to raise_error RuntimeError
+        expect { subject.get('foo') }.to raise_error StandardError
+      end
+    end
+
+    context 'when there is a 401 error' do
+      let(:code) { 401 }
+      it 'should raise an Unauthorized error' do
+        expect(subject.class).to receive(:get).with('foo', anything).and_return(response)
+        expect { subject.get('foo') }.to raise_error Dotloop::Unauthorized
+      end
+    end
+
+    context 'when there is a 403 error' do
+      let(:code) { 403 }
+      it 'should raise an Forbidden error' do
+        expect(subject.class).to receive(:get).with('foo', anything).and_return(response)
+        expect { subject.get('foo') }.to raise_error Dotloop::Forbidden
       end
     end
 

spec/dotloop/document_spec.rb

@@ -1,5 +1,6 @@
 require_relative '../spec_helper'
 
+# rubocop:disable Metrics/BlockLength
 RSpec.describe Dotloop::Document do
   let(:client) { Dotloop::Client.new(api_key: SecureRandom.uuid) }
   subject { Dotloop::Document.new(client: client) }

spec/dotloop/employee_spec.rb

@@ -1,5 +1,6 @@
 require_relative '../spec_helper'
 
+# rubocop:disable Metrics/BlockLength
 RSpec.describe Dotloop::Employee do
   let(:client) { Dotloop::Client.new(api_key: SecureRandom.uuid) }
   subject { Dotloop::Employee.new(client: client) }

spec/dotloop/loop_spec.rb

@@ -1,5 +1,6 @@
 require_relative '../spec_helper'
 
+# rubocop:disable Metrics/BlockLength
 RSpec.describe Dotloop::Loop do
   let(:client) { Dotloop::Client.new(api_key: SecureRandom.uuid) }
   subject { Dotloop::Loop.new(client: client) }
@@ -54,7 +55,7 @@
       ).and_return([])
       subject.all(
         profile_id: '1234',
-        statuses: %i(private_listing active_listing under_contract),
+        statuses: %i[private_listing active_listing under_contract],
         compliance_status_ids: [3, 4, 5],
         tag_ids: [6, 7, 8],
         sort_by: 'sort me',
@@ -114,7 +115,7 @@
   end
 
   describe '#statuses' do
-    let(:status_list) { %i(private_listing active_listing under_contract sold leased archived pre_listing pre_offer) }
+    let(:status_list) { %i[private_listing active_listing under_contract sold leased archived pre_listing pre_offer] }
     it { expect(subject.statuses).to match_array(status_list) }
   end
 end

spec/dotloop/models/document_spec.rb

@@ -1,5 +1,6 @@
 require_relative '../../spec_helper'
 
+# rubocop:disable Metrics/BlockLength
 RSpec.describe Dotloop::Models::Loop do
   let(:profile_id) { 1234 }
   let(:loop_view_id) { 76_046 }

spec/dotloop/models/loop_spec.rb

@@ -1,5 +1,6 @@
 require_relative '../../spec_helper'
 
+# rubocop:disable Metrics/BlockLength
 RSpec.describe Dotloop::Models::Loop do
   let(:profile_id) { 1234 }
   let(:loop_view_id) { 76_046 }

spec/dotloop/person_spec.rb

@@ -1,5 +1,6 @@
 require_relative '../spec_helper'
 
+# rubocop:disable Metrics/BlockLength
 RSpec.describe Dotloop::Person do
   let(:client) { Dotloop::Client.new(api_key: SecureRandom.uuid) }
   subject { Dotloop::Person.new(client: client) }

spec/dotloop/profile_spec.rb

@@ -1,5 +1,6 @@
 require_relative '../spec_helper'
 
+# rubocop:disable Metrics/BlockLength
 RSpec.describe Dotloop::Profile do
   let(:client) { Dotloop::Client.new(api_key: SecureRandom.uuid) }
   subject { Dotloop::Profile.new(client: client) }

spec/dotloop/section_spec.rb

@@ -1,5 +1,6 @@
 require_relative '../spec_helper'
 
+# rubocop:disable Metrics/BlockLength
 RSpec.describe Dotloop::Section do
   let(:client) { Dotloop::Client.new(api_key: SecureRandom.uuid) }
   let(:loop) { Dotloop::Loop.new(client: client) }

spec/dotloop/task_spec.rb

@@ -1,5 +1,6 @@
 require_relative '../spec_helper'
 
+# rubocop:disable Metrics/BlockLength
 RSpec.describe Dotloop::Task do
   let(:client) { Dotloop::Client.new(api_key: SecureRandom.uuid) }
   subject { Dotloop::Task.new(client: client) }