Merge pull request #6 from Loft47/chore/refactor-document

The Document endpoint was consuming the loop_view_id, not the loop_id
Loft47 · Jul 27, 2016 · c04b5b4 · c04b5b4
2 parents f3f07ba + 931677d
commit c04b5b4
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 6 deletions.
diff --git a/lib/dotloop/document.rb b/lib/dotloop/document.rb
@@ -6,18 +6,20 @@ def initialize(client:)
       @client = client
     end
 
-    def all(profile_id:, loop_id:)
-      @client.get("/profile/#{profile_id.to_i}/loop/#{loop_id.to_i}/document").map do |document_attrs|
+    def all(profile_id:, loop_view_id:)
+      @client.get("/profile/#{profile_id.to_i}/loop/#{loop_view_id.to_i}/document").map do |document_attrs|
         doc = Dotloop::Models::Document.new(document_attrs)
         doc.client = client
         doc
       end
     end
 
-    def get(profile_id:, loop_id:, document_id:, document_name:)
+    def get(profile_id:, loop_view_id:, document_id:, document_name:)
       document_name = CGI.escape(document_name)
       StringIO.new(
-        @client.raw("/profile/#{profile_id.to_i}/loop/#{loop_id.to_i}/document/#{document_id}/#{document_name}.pdf")
+        @client.raw(
+          "/profile/#{profile_id.to_i}/loop/#{loop_view_id.to_i}/document/#{document_id}/#{document_name}.pdf"
+        )
       )
     end
   end

diff --git a/spec/dotloop/document_spec.rb b/spec/dotloop/document_spec.rb
@@ -17,7 +17,7 @@
   describe '#all' do
     it 'should return a list of documents' do
       dotloop_mock(:documents)
-      documents = subject.all(profile_id: 1_234, loop_id: 76_046)
+      documents = subject.all(profile_id: 1_234, loop_view_id: 76_046)
       expect(documents).to_not be_empty
       expect(documents).to all(be_a(Dotloop::Models::Document))
       expect(documents.first).to have_attributes(
@@ -38,7 +38,7 @@
     it 'should get pdf data' do
       dotloop_pdf
       document = subject.get(profile_id: 1_234,
-                             loop_id: 76_046,
+                             loop_view_id: 76_046,
                              document_id: 561_622,
                              document_name: 'AgencyDisclosureStatementSeller')
       expect(document.string).to eq(disclosure_file_data)