Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the internal dependencies on the Illuminate helpers assumed to be provided by Sage 9/10. With this change, Navi should now be usable in any WordPress environment. I've done some minimal testing on an existing project, but more testing would certainly be wise.
This would represent a⚠️ breaking change ⚠️ if implemented: It strips out all Fluent functionality, so any user implementation depending on Fluent methods will immediately explode. If this is a real no-go, then I can look at just manually copying over the classes, etc, since we want to avoid any dependencies (and thus dependency hell w/ relatively popular packages). I left that out in this initial PR for the following reasons:
Also of note:
I've added a method called
getItems()
which returns an array of items (i.e. you'd use it astoArray()
is used in the original examples). I did this becausetoArray()
makes no semantic sense when all internal data is now arrays. However I have added atoArray()
method as well that just returnsgetItems()
to make the transition from older user implementations a little easier.Let me know if you'd like me to make any changes or take it in a different direction.